From 7640a7b4a39a9ff33e307e613d1ba90113d4d73f Mon Sep 17 00:00:00 2001
From: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Date: Mon, 28 Aug 2023 18:43:43 -0700
Subject: [PATCH] Add back "Install" text on welcome page button and remove
 tooltip (#24214)

* remove tooltip from install button on welcome page

* fix missing Install text
---
 src/sql/workbench/contrib/welcome/browser/welcomePage.ts | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/sql/workbench/contrib/welcome/browser/welcomePage.ts b/src/sql/workbench/contrib/welcome/browser/welcomePage.ts
index cc974ecaf5..19e33c9b5a 100644
--- a/src/sql/workbench/contrib/welcome/browser/welcomePage.ts
+++ b/src/sql/workbench/contrib/welcome/browser/welcomePage.ts
@@ -577,12 +577,12 @@ class WelcomePage extends Disposable {
 		if (btnContainer) {
 			extensionPacks.forEach((extension) => {
 				const installText = localize('welcomePage.install', "Install");
-				this._register(new Button(btnContainer, { title: installText, supportIcons: true, ...defaultButtonStyles }));
+				let dropdownBtn = this._register(new Button(btnContainer, { supportIcons: true, ...defaultButtonStyles }));
+				dropdownBtn.label = installText;
 				const classes = ['btn'];
 				const getDropdownBtn = container.querySelector('.extensionPack .monaco-button:first-of-type') as HTMLAnchorElement;
 				getDropdownBtn.id = 'dropdown-btn';
 				getDropdownBtn.classList.add(...classes);
-				getDropdownBtn.title = extension.title || (extension.isKeymap ? localize('welcomePage.installKeymap', "Install {0} keymap", extension.name) : localize('welcomePage.installExtensionPack', "Install additional support for {0}", extension.name));
 				getDropdownBtn.setAttribute('aria-haspopup', 'true');
 				getDropdownBtn.setAttribute('aria-controls', 'dropdown');
 				getDropdownBtn.setAttribute('role', 'navigation');
@@ -602,7 +602,7 @@ class WelcomePage extends Disposable {
 				const header = container.querySelector('.extension-pack-header');
 
 				const installedText = localize('welcomePage.installed', "Installed");
-				let installedButton = new Button(btnContainer, { title: installedText, supportIcons: true, ...defaultButtonStyles });
+				let installedButton = new Button(btnContainer, { supportIcons: true, ...defaultButtonStyles });
 				this._register(installedButton);
 
 				installedButton.label = installedText;
@@ -610,7 +610,6 @@ class WelcomePage extends Disposable {
 				const getInstalledButton = container.querySelector('.extensionPack .monaco-button:nth-of-type(2)') as HTMLAnchorElement;
 
 				getInstalledButton.innerText = localize('welcomePage.installed', "Installed");
-				getInstalledButton.title = extension.isKeymap ? localize('welcomePage.installedKeymap', "{0} keymap is already installed", extension.name) : localize('welcomePage.installedExtensionPack', "{0} support is already installed", extension.name);
 				getInstalledButton.classList.add('enabledExtension');
 				getInstalledButton.classList.add(...classes);
 				getInstalledButton.setAttribute('data-extension', extension.id);