ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

wait for kernel change before running cell (#12949)

Browse Source
This commit is contained in:
Lucy Zhang
2020-10-16 09:59:03 -07:00
committed by GitHub
parent f6949d834b
commit 767465edbf
3 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/automation/src/sql/configurePythonDialog.ts
View File

@@ -33,7 +33,13 @@ export class ConfigurePythonDialog extends Dialog {
await this.code.waitForElement(installButton); await this.code.waitForElement(installButton);
await this.code.dispatchKeybinding('enter'); await this.code.dispatchKeybinding('enter');
return this.waitForDialogGone(); await this.waitForDialogGone();
return this._waitForInstallationComplete();
}
private async _waitForInstallationComplete(): Promise<void> {
const installationCompleteNotification = '.notifications-toasts div[aria-label="Notebook dependencies installation is complete, source: Notebook Core Extensions (Extension), notification"]';
await this.code.waitForElement(installationCompleteNotification);
} }
} }

9
test/automation/src/sql/notebook.ts
View File

@@ -46,6 +46,10 @@ export class Notebook {
await this.toolbar.changeKernel(kernel); await this.toolbar.changeKernel(kernel);
} }
async waitForKernel(kernel: string): Promise<void> {
await this.toolbar.waitForKernel(kernel);
}
async runActiveCell(): Promise<void> { async runActiveCell(): Promise<void> {
await this.code.dispatchKeybinding('F5'); await this.code.dispatchKeybinding('F5');
} }
@@ -86,4 +90,9 @@ export class NotebookToolbar {
await this.code.waitForSetValue(kernelDropdown, kernel); await this.code.waitForSetValue(kernelDropdown, kernel);
await this.code.dispatchKeybinding('enter'); await this.code.dispatchKeybinding('enter');
} }
async waitForKernel(kernel: string): Promise<void> {
const kernelDropdownValue = `${NotebookToolbar.toolbarSelector} select[id="kernel-dropdown"][title="${kernel}"]`;
await this.code.waitForElement(kernelDropdownValue);
}
} }

1
test/smoke/src/sql/areas/notebook/notebook.test.ts
View File

@@ -18,6 +18,7 @@ export function setup() {
await app.workbench.sqlNotebook.changeKernel('Python 3'); await app.workbench.sqlNotebook.changeKernel('Python 3');
await app.workbench.configurePythonDialog.waitForConfigurePythonDialog(); await app.workbench.configurePythonDialog.waitForConfigurePythonDialog();
await app.workbench.configurePythonDialog.installPython(); await app.workbench.configurePythonDialog.installPython();
await app.workbench.sqlNotebook.waitForKernel('Python 3');
await app.workbench.sqlNotebook.runActiveCell(); await app.workbench.sqlNotebook.runActiveCell();
await app.workbench.sqlNotebook.waitForResults(); await app.workbench.sqlNotebook.waitForResults();