ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-04 01:25:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix rest of notebook unhandled promises (#16933)

Browse Source 
* Fix rest of notebook unhandled promises

* add rule

* fix some tests
This commit is contained in:
Charles Gagnon
2021-08-30 14:14:48 -07:00
committed by GitHub
parent 26e08fdf9e
commit 76e01fee60
21 changed files with 79 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
extensions/notebook/src/dialog/remoteBookDialog.ts
View File

@@ -100,7 +100,7 @@ export class RemoteBookDialog {
}).component();
this.languageDropdown.onValueChanged(async () => this.checkValues());
this.setFieldsToEmpty();
await this.setFieldsToEmpty();
this.formModel = this.view.modelBuilder.formContainer()
.withFormItems([{
@@ -191,7 +191,7 @@ export class RemoteBookDialog {
if (releases) {
this.releaseDropdown.enabled = true;
await this.fillReleasesDropdown();
this.setFieldsToEmpty();
await this.setFieldsToEmpty();
}
} else {
throw new Error(loc.urlGithubError);
@@ -200,7 +200,7 @@ export class RemoteBookDialog {
}
catch (error) {
await this.fillReleasesDropdown();
this.setFieldsToEmpty();
await this.setFieldsToEmpty();
this.showErrorMessage(error.message);
}
}
@@ -219,7 +219,7 @@ export class RemoteBookDialog {
}
}
catch (error) {
this.setFieldsToEmpty();
await this.setFieldsToEmpty();
this.showErrorMessage(error.message);
}
}