ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-03-26 14:50:31 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix rest of notebook unhandled promises (#16933)

Browse Source 
* Fix rest of notebook unhandled promises

* add rule

* fix some tests
This commit is contained in:
Charles Gagnon
2021-08-30 14:14:48 -07:00
committed by GitHub
parent 26e08fdf9e
commit 76e01fee60
21 changed files with 79 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/notebook/src/jupyter/jupyterServerInstallation.ts
View File

@@ -509,7 +509,7 @@ export class JupyterServerInstallation implements IJupyterServerInstallation {
// If the latest version of ADS-Python is not installed, then prompt the user to upgrade
if (!this._upgradePrompted && isPythonInstalled && !this._usingExistingPython && utils.compareVersions(await this.getInstalledPythonVersion(this._pythonExecutable), constants.pythonVersion) < 0) {
this._upgradePrompted = true;
this.promptUserForPythonUpgrade();
await this.promptUserForPythonUpgrade();
}
let areRequiredPackagesInstalled = await this.areRequiredPackagesInstalled(kernelDisplayName);