ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-31 09:35:39 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix rest of notebook unhandled promises (#16933)

Browse Source 
* Fix rest of notebook unhandled promises

* add rule

* fix some tests
This commit is contained in:
Charles Gagnon
2021-08-30 14:14:48 -07:00
committed by GitHub
parent 26e08fdf9e
commit 76e01fee60
21 changed files with 79 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/notebook/src/test/model/jupyterController.test.ts
View File

@@ -78,7 +78,7 @@ describe('Jupyter Controller', function () {
await controller.activate();
should(controller.notebookProvider.standardKernels).deepEqual([], 'Notebook provider standard kernels should return empty array');
should(controller.notebookProvider.providerId).equal('jupyter', 'Notebook provider should be jupyter');
should(controller.notebookProvider.getNotebookManager(undefined)).be.rejected();
await should(controller.notebookProvider.getNotebookManager(undefined)).be.rejected();
should(controller.notebookProvider.notebookManagerCount).equal(0);
controller.notebookProvider.handleNotebookClosed(undefined);
});

10
extensions/notebook/src/test/model/kernel.test.ts
View File

@@ -146,7 +146,7 @@ describe('Jupyter Future', function (): void {
})
});
should(handler).not.be.undefined();
verifyRelayMessage('shell', handler, () => msg);
await verifyRelayMessage('shell', handler, () => msg);
});
@@ -162,7 +162,7 @@ describe('Jupyter Future', function (): void {
})
});
should(handler).not.be.undefined();
verifyRelayMessage('stdin', handler, () => msg);
await verifyRelayMessage('stdin', handler, () => msg);
});
it('should relay IOPub message', async function (): Promise<void> {
@@ -177,11 +177,11 @@ describe('Jupyter Future', function (): void {
})
});
should(handler).not.be.undefined();
verifyRelayMessage('iopub', handler, () => msg);
await verifyRelayMessage('iopub', handler, () => msg);
});
function verifyRelayMessage(channel: nb.Channel | KernelMessage.Channel, handler: (msg: KernelMessage.IMessage) => void | PromiseLike<void>, getMessage: () => nb.IMessage): void {
handler({
async function verifyRelayMessage(channel: nb.Channel | KernelMessage.Channel, handler: (msg: KernelMessage.IMessage) => void | PromiseLike<void>, getMessage: () => nb.IMessage): Promise<void> {
await handler({
channel: <any>channel,
content: { value: 'test' },
metadata: { value: 'test' },

4
extensions/notebook/src/test/model/sessionManager.test.ts
View File

@@ -65,7 +65,7 @@ describe('Jupyter Session Manager', function (): void {
sessionManager.ready.then(() => {
should(sessionManager.isReady).be.true();
done();
});
}).catch(err => done(err));
});
it('should passthrough the ready calls', function (done): void {
@@ -75,7 +75,7 @@ describe('Jupyter Session Manager', function (): void {
// When I wait on the ready method before completing
sessionManager.setJupyterSessionManager(mockJupyterManager.object);
sessionManager.ready.then(() => done());
sessionManager.ready.then(() => done()).catch(err => done(err));
// Then session manager should eventually resolve
deferred.resolve();