From 77413ad25c2f21606f1fbe911991e791d433a34f Mon Sep 17 00:00:00 2001 From: kisantia <31145923+kisantia@users.noreply.github.com> Date: Tue, 21 May 2019 09:23:43 -0700 Subject: [PATCH] Schema compare server dropdown changes (#5552) * remove duplicate server entries in server dropdown * change server dropdown to show most recent connections first --- .../src/dialogs/schemaCompareDialog.ts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/extensions/schema-compare/src/dialogs/schemaCompareDialog.ts b/extensions/schema-compare/src/dialogs/schemaCompareDialog.ts index afda8ebc4b..5417b8aa62 100644 --- a/extensions/schema-compare/src/dialogs/schemaCompareDialog.ts +++ b/extensions/schema-compare/src/dialogs/schemaCompareDialog.ts @@ -416,7 +416,6 @@ export class SchemaCompareDialog { idx = count; } - let db = c.options.databaseDisplayName; let usr = c.options.user; let srv = c.options.server; @@ -432,6 +431,17 @@ export class SchemaCompareDialog { }; }); + values = values.reduce((uniqueValues, conn) => { + let exists = uniqueValues.find(x => x.displayName === conn.displayName); + if (!exists) { + uniqueValues.push(conn); + } + return uniqueValues; + }, []); + + // reverse list so that most recent connections show first + values.reverse(); + // move server of current connection to the top of the list so it is the default if (idx >= 1) { let tmp = values[0];