ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-23 17:23:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add collapsed argument to insertCell extension method. (#7635)

Browse Source
This commit is contained in:
Cory Rivera
2019-10-10 14:06:31 -07:00
committed by GitHub
parent bf00a6b695
commit 777c188a3f
3 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/sql/workbench/api/common/extHostNotebookEditor.ts
View File

@@ -13,6 +13,7 @@ import { readonly } from 'vs/base/common/errors';
import { MainThreadNotebookDocumentsAndEditorsShape } from 'sql/workbench/api/common/sqlExtHost.protocol';
import { ExtHostNotebookDocumentData } from 'sql/workbench/api/common/extHostNotebookDocumentData';
import { CellRange, ISingleNotebookEditOperation, ICellRange } from 'sql/workbench/api/common/sqlExtHostTypes';
import { HideInputTag } from 'sql/workbench/parts/notebook/browser/models/cell';
export interface INotebookEditOperation {
range: azdata.nb.CellRange;
@@ -80,12 +81,21 @@ export class NotebookEditorEdit {
return range;
}
insertCell(value: Partial<azdata.nb.ICellContents>, location?: number): void {
if (location === null || location === undefined) {
insertCell(value: Partial<azdata.nb.ICellContents>, index?: number, collapsed?: boolean): void {
if (index === null || index === undefined) {
// If not specified, assume adding to end of list
location = this._document.cells.length;
index = this._document.cells.length;
}
this._pushEdit(new CellRange(location, location), value, true);
if (!!collapsed) {
if (!value.metadata) {
value.metadata = { tags: [HideInputTag] };
} else if (!value.metadata.tags) {
value.metadata.tags = [HideInputTag];
} else if (!value.metadata.tags.includes(HideInputTag)) {
value.metadata.tags.push(HideInputTag);
}
}
this._pushEdit(new CellRange(index, index), value, true);
}
deleteCell(index: number): void {

10
src/sql/workbench/parts/notebook/browser/models/cell.ts
View File

@@ -24,6 +24,8 @@ import { generateUuid } from 'vs/base/common/uuid';
import { IModelContentChangedEvent } from 'vs/editor/common/model/textModelEvents';
let modelId = 0;
export const HideInputTag = 'hide_input';
export class CellModel implements ICellModel {
public id: string;
@@ -52,8 +54,6 @@ export class CellModel implements ICellModel {
private _onCollapseStateChanged = new Emitter<boolean>();
private _modelContentChangedEvent: IModelContentChangedEvent;
private readonly _hideInputTag = 'hide_input';
constructor(cellData: nb.ICellContents,
private _options: ICellModelOptions,
@optional(INotebookService) private _notebookService?: INotebookService
@@ -112,7 +112,7 @@ export class CellModel implements ICellModel {
let tagIndex = -1;
if (this._metadata.tags) {
tagIndex = this._metadata.tags.findIndex(tag => tag === this._hideInputTag);
tagIndex = this._metadata.tags.findIndex(tag => tag === HideInputTag);
}
if (this._isCollapsed) {
@@ -120,7 +120,7 @@ export class CellModel implements ICellModel {
if (!this._metadata.tags) {
this._metadata.tags = [];
}
this._metadata.tags.push(this._hideInputTag);
this._metadata.tags.push(HideInputTag);
}
} else {
if (tagIndex > -1) {
@@ -605,7 +605,7 @@ export class CellModel implements ICellModel {
this._source = this.getMultilineSource(cell.source);
this._metadata = cell.metadata || {};
if (this._metadata.tags && this._metadata.tags.includes(this._hideInputTag)) {
if (this._metadata.tags && this._metadata.tags.includes(HideInputTag)) {
this._isCollapsed = true;
} else {
this._isCollapsed = false;