Fix open external not working (#17717)

This commit is contained in:
Charles Gagnon
2021-11-19 11:25:23 -08:00
committed by GitHub
parent 8a6ea2669b
commit 77e4fdd407
2 changed files with 14 additions and 12 deletions

View File

@@ -327,7 +327,7 @@ export class ResultSerializer {
} else { } else {
this._notificationService.prompt( this._notificationService.prompt(
Severity.Info, Severity.Info,
nls.localize('msgSaveSucceeded', "Successfully saved results to {0}", filePath.path), nls.localize('msgSaveSucceeded', "Successfully saved results to {0}", filePath.fsPath),
[{ [{
label: nls.localize('openFile', "Open file"), label: nls.localize('openFile', "Open file"),
run: () => { run: () => {

View File

@@ -519,18 +519,20 @@ export class NativeWindow extends Disposable {
} }
} }
// Assume `uri` this is a workspace uri, let's see if we can handle it if (!options?.openExternal) {
await this.fileService.activateProvider(uri.scheme); // Assume `uri` this is a workspace uri, let's see if we can handle it
await this.fileService.activateProvider(uri.scheme);
if (this.fileService.canHandleResource(uri)) { if (this.fileService.canHandleResource(uri)) {
return { return {
resolved: URI.from({ resolved: URI.from({
scheme: this.productService.urlProtocol, scheme: this.productService.urlProtocol,
path: 'workspace', path: 'workspace',
query: uri.toString() query: uri.toString()
}), }),
dispose() { } dispose() { }
}; };
}
} }
return undefined; return undefined;