ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix issues with unknown notebook file types not opening as a default notebook. (#18779)

Browse Source
This commit is contained in:
Cory Rivera
2022-03-18 16:59:22 -07:00
committed by GitHub
parent 23a69f9b69
commit 7914fcf101
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/workbench/services/notebook/browser/models/notebookUtils.ts
View File

@@ -29,11 +29,11 @@ export function getProvidersForFileName(fileName: string, notebookService: INote
providers = notebookService.getProvidersForFileType(fileExt); providers = notebookService.getProvidersForFileType(fileExt);
} }
// Fallback to provider for default file type (assume this is a global handler) // Fallback to provider for default file type (assume this is a global handler)
if (!providers) { if (!providers || providers.length === 0) {
providers = notebookService.getProvidersForFileType(DEFAULT_NOTEBOOK_FILETYPE); providers = notebookService.getProvidersForFileType(DEFAULT_NOTEBOOK_FILETYPE);
} }
// Finally if all else fails, use the built-in handler // Finally if all else fails, use the built-in handler
if (!providers) { if (!providers || providers.length === 0) {
providers = [DEFAULT_NOTEBOOK_PROVIDER]; providers = [DEFAULT_NOTEBOOK_PROVIDER];
} }
return providers; return providers;

2
src/sql/workbench/services/notebook/browser/notebookServiceImpl.ts
View File

@@ -510,7 +510,7 @@ export class NotebookService extends Disposable implements INotebookService {
getProvidersForFileType(fileType: string): string[] | undefined { getProvidersForFileType(fileType: string): string[] | undefined {
let provDescriptions = this._fileToProviderDescriptions.get(fileType.toLowerCase()); let provDescriptions = this._fileToProviderDescriptions.get(fileType.toLowerCase());
let providers = provDescriptions?.map(provider => provider.provider); let providers = provDescriptions?.map(provider => provider.provider);
return [...new Set(providers)]; // Remove duplicates return providers ? [...new Set(providers)] : undefined; // Use a set to remove duplicates
} }
public async getStandardKernelsForProvider(provider: string): Promise<nb.IStandardKernel[] | undefined> { public async getStandardKernelsForProvider(provider: string): Promise<nb.IStandardKernel[] | undefined> {