From f5a866aa423983169f4ea81898169416bdc0a35f Mon Sep 17 00:00:00 2001 From: Anthony Dresser Date: Wed, 14 Feb 2018 10:21:04 -0800 Subject: [PATCH 1/2] clone value to keep from getting previous settings (#688) --- .../dashboard/services/dashboardServiceInterface.service.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/sql/parts/dashboard/services/dashboardServiceInterface.service.ts b/src/sql/parts/dashboard/services/dashboardServiceInterface.service.ts index df790a33a3..c12043f3ce 100644 --- a/src/sql/parts/dashboard/services/dashboardServiceInterface.service.ts +++ b/src/sql/parts/dashboard/services/dashboardServiceInterface.service.ts @@ -37,6 +37,7 @@ import { IStorageService } from 'vs/platform/storage/common/storage'; import Event, { Emitter } from 'vs/base/common/event'; import Severity from 'vs/base/common/severity'; import * as nls from 'vs/nls'; +import { deepClone } from 'vs/base/common/objects'; const DASHBOARD_SETTINGS = 'dashboard'; @@ -251,7 +252,7 @@ export class DashboardServiceInterface implements OnDestroy { */ public getSettings(type: string): T { let config = this._configService.getValue([DASHBOARD_SETTINGS, type].join('.')); - return config; + return deepClone(config); } public writeSettings(key: string, value: any, target: ConfigurationTarget) { From 49d19a9ab8ee3f57ca9416d9e1ac1e44e2c6144f Mon Sep 17 00:00:00 2001 From: Karl Burtram Date: Wed, 14 Feb 2018 10:23:05 -0800 Subject: [PATCH 2/2] Bump SQL Ops to 0.26.5 (#691) --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 17532f5c14..d41fb988ca 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "sqlops", - "version": "0.26.4", + "version": "0.26.5", "distro": "8c3e97e3425cc9814496472ab73e076de2ba99ee", "author": { "name": "Microsoft Corporation"