ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix for Schema compare Options dialog double scroll (#5584)

Browse Source 
* setting height through vh removes outser scroll (% does not work)

* Chainging auto to scroll for overflow for better viewing
This commit is contained in:
udeeshagautam
2019-05-23 15:51:52 -07:00
committed by GitHub
parent fbbf767700
commit 7b01a6ca61
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
extensions/schema-compare/src/dialogs/schemaCompareOptionsDialog.ts
View File

@@ -460,7 +460,6 @@ export class SchemaCompareOptionsDialog {
this.optionsFlexBuilder = view.modelBuilder.flexContainer() this.optionsFlexBuilder = view.modelBuilder.flexContainer()
.withLayout({ .withLayout({
flexFlow: 'column', flexFlow: 'column',
height: 760,
}).component(); }).component();
this.descriptionHeading = view.modelBuilder.table().withProperties({ this.descriptionHeading = view.modelBuilder.table().withProperties({
@@ -470,13 +469,11 @@ export class SchemaCompareOptionsDialog {
headerCssClass: 'no-borders', headerCssClass: 'no-borders',
toolTip: 'Option Description' toolTip: 'Option Description'
}, },
], ]
height: 30
}).component(); }).component();
this.descriptionText = view.modelBuilder.text().withProperties({ this.descriptionText = view.modelBuilder.text().withProperties({
value: ' ', value: ' '
height: 100
}).component(); }).component();
this.GetGeneralOptionCheckBoxes(view); this.GetGeneralOptionCheckBoxes(view);
@@ -489,9 +486,9 @@ export class SchemaCompareOptionsDialog {
flexFlow: 'column', flexFlow: 'column',
}).component(); }).component();
uberOptionsFlexBuilder.addItem(this.optionsFlexBuilder, { CSSStyles: { 'overflow': 'scroll' } }); uberOptionsFlexBuilder.addItem(this.optionsFlexBuilder, { CSSStyles: { 'overflow': 'scroll', 'height': '65vh' } });
uberOptionsFlexBuilder.addItem(this.descriptionHeading, { CSSStyles: { 'font-weight': 'bold' } }); uberOptionsFlexBuilder.addItem(this.descriptionHeading, { CSSStyles: { 'font-weight': 'bold', 'height': '30px' } });
uberOptionsFlexBuilder.addItem(this.descriptionText, { CSSStyles: { 'padding': '4px' } }); uberOptionsFlexBuilder.addItem(this.descriptionText, { CSSStyles: { 'padding': '4px', 'overflow': 'scroll', 'height': '10vh' } });
await view.initializeModel(uberOptionsFlexBuilder); await view.initializeModel(uberOptionsFlexBuilder);
}); });
} }