ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-23 09:35:39 -05:00
Code Issues Packages Projects Releases Wiki Activity

Respect 'showDashboard' disabled by default (#22907)

Browse Source
This commit is contained in:
Cheena Malhotra
2023-05-01 11:55:38 -07:00
committed by GitHub
parent ea6bb41f45
commit 7b2a07befd
15 changed files with 39 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/workbench/services/connection/browser/connectionDialogService.ts
View File

@@ -265,7 +265,7 @@ export class ConnectionDialogService implements IConnectionDialogService {
let options: IConnectionCompletionOptions = this._options || {
params: params,
saveTheConnection: !isTemporaryConnection,
showDashboard: params && params.showDashboard !== undefined ? params.showDashboard : !fromEditor && !isTemporaryConnection,
showDashboard: params?.showDashboard ?? false,
showConnectionDialogOnError: false,
showFirewallRuleOnError: true
};

3
src/sql/workbench/services/connection/browser/connectionManagementService.ts
View File

@@ -492,7 +492,6 @@ export class ConnectionManagementService extends Disposable implements IConnecti
saveTheConnection: saveConnection,
showConnectionDialogOnError: true,
showDashboard: purpose === 'dashboard',
params: undefined,
showFirewallRuleOnError: true,
};
return this.connect(connection, ownerUri, options).then(connectionResult => {
@@ -524,7 +523,6 @@ export class ConnectionManagementService extends Disposable implements IConnecti
options = {
saveTheConnection: true,
showDashboard: false,
params: undefined,
showConnectionDialogOnError: false,
showFirewallRuleOnError: true
};
@@ -574,7 +572,6 @@ export class ConnectionManagementService extends Disposable implements IConnecti
options = {
saveTheConnection: false,
showDashboard: false,
params: undefined,
showConnectionDialogOnError: false,
showFirewallRuleOnError: true
};