ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add markdown smoke tests for changing text size and inserting links (#18888)

Browse Source 
* Temporarily disabled text size tests due to issues running on Unix.
This commit is contained in:
Cory Rivera
2022-04-05 15:53:06 -07:00
committed by GitHub
parent 92a2233022
commit 7c399e84eb
3 changed files with 68 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/workbench/contrib/notebook/browser/cellViews/markdownToolbar.component.ts
View File

@@ -189,7 +189,7 @@ export class MarkdownToolbarComponent extends AngularDisposable {
undefined, undefined,
this._actionBar.actionRunner, this._actionBar.actionRunner,
undefined, undefined,
'masked-pseudo-after dropdown-arrow', 'masked-pseudo-after dropdown-arrow heading-dropdown',
this.optionParagraph, this.optionParagraph,
undefined undefined
); );

26
test/automation/src/sql/notebook.ts
View File

@@ -9,8 +9,8 @@ import { QuickInput } from '../quickinput';
import { Editors } from '../editors'; import { Editors } from '../editors';
import { IElement } from '..'; import { IElement } from '..';
const winOrCtrl = process.platform === 'win32' ? 'win' : 'ctrl'; const winOrCtrl = process.platform === 'darwin' ? 'ctrl' : 'win';
const ctrlOrCmd = process.platform === 'win32' ? 'ctrl' : 'cmd'; const ctrlOrCmd = process.platform === 'darwin' ? 'cmd' : 'ctrl';
export class Notebook { export class Notebook {
@@ -233,8 +233,16 @@ export class TextCellToolbar {
await this.clickToolbarButton('Insert code'); await this.clickToolbarButton('Insert code');
} }
public async insertLink(): Promise<void> { public async insertLink(linkLabel: string, linkAddress: string): Promise<void> {
throw new Error('Method not implemented.'); await this.clickToolbarButton('Insert link');
const linkDialogSelector = 'div.modal.callout-dialog[aria-label="Insert link"]';
const displayTextSelector = `${linkDialogSelector} input[aria-label="Text to display"]`;
await this.code.waitForSetValue(displayTextSelector, linkLabel);
const addressTextSelector = `${linkDialogSelector} input[aria-label="Address"]`;
await this.code.waitForSetValue(addressTextSelector, linkAddress);
await this.code.dispatchKeybinding('enter');
} }
public async insertList(): Promise<void> { public async insertList(): Promise<void> {
@@ -245,9 +253,13 @@ export class TextCellToolbar {
await this.clickToolbarButton('Insert ordered list'); await this.clickToolbarButton('Insert ordered list');
} }
public async changeSelectedTextSize(): Promise<void> { // Disabled since the text size dropdown is not clickable on Unix from smoke tests
throw new Error('Method not implemented.'); // public async changeSelectedTextSize(textSize: 'Heading 1' | 'Heading 2' | 'Heading 3' | 'Paragraph'): Promise<void> {
} // const actionSelector = `${TextCellToolbar.textCellToolbar} .monaco-dropdown a.heading-dropdown`;
// await this.code.waitAndClick(actionSelector);
// const menuItemSelector = `.context-view.monaco-menu-container .monaco-menu .action-menu-item[title="${textSize}"]`;
// await this.code.waitAndClick(menuItemSelector);
// }
private async clickToolbarButton(buttonTitle: string) { private async clickToolbarButton(buttonTitle: string) {
const actionSelector = `${TextCellToolbar.textCellToolbar} a[title="${buttonTitle}"]`; const actionSelector = `${TextCellToolbar.textCellToolbar} a[title="${buttonTitle}"]`;

48
test/smoke/src/sql/areas/notebook/notebook.test.ts
View File

@@ -211,6 +211,54 @@ export function setup(opts: minimist.ParsedArgs) {
await app.code.dispatchKeybinding('escape'); await app.code.dispatchKeybinding('escape');
await app.workbench.sqlNotebook.waitForTextCellPreviewContent(sampleText, 'ol li'); await app.workbench.sqlNotebook.waitForTextCellPreviewContent(sampleText, 'ol li');
}); });
// Text size tests are disabled because the text size dropdown
// is not clickable on Unix from the smoke tests
// it('can change text size to Heading 1', async function () {
// const app = this.app as Application;
// await createCellAndSelectAllText(app);
// await app.workbench.sqlNotebook.textCellToolbar.changeSelectedTextSize('Heading 1');
// await app.code.dispatchKeybinding('escape');
// await app.workbench.sqlNotebook.waitForTextCellPreviewContent(sampleText, 'h1');
// });
// it('can change text size to Heading 2', async function () {
// const app = this.app as Application;
// await createCellAndSelectAllText(app);
// await app.workbench.sqlNotebook.textCellToolbar.changeSelectedTextSize('Heading 2');
// await app.code.dispatchKeybinding('escape');
// await app.workbench.sqlNotebook.waitForTextCellPreviewContent(sampleText, 'h2');
// });
// it('can change text size to Heading 3', async function () {
// const app = this.app as Application;
// await createCellAndSelectAllText(app);
// await app.workbench.sqlNotebook.textCellToolbar.changeSelectedTextSize('Heading 3');
// await app.code.dispatchKeybinding('escape');
// await app.workbench.sqlNotebook.waitForTextCellPreviewContent(sampleText, 'h3');
// });
// it('can change text size to Paragraph', async function () {
// const app = this.app as Application;
// await createCellAndSelectAllText(app);
// await app.workbench.sqlNotebook.textCellToolbar.changeSelectedTextSize('Paragraph');
// await app.code.dispatchKeybinding('escape');
// await app.workbench.sqlNotebook.waitForTextCellPreviewContent(sampleText, 'p');
// });
it('can insert link', async function () {
const app = this.app as Application;
await app.workbench.sqlNotebook.newUntitledNotebook();
await app.workbench.sqlNotebook.addCellFromPlaceholder('Markdown');
await app.workbench.sqlNotebook.waitForPlaceholderGone();
await app.workbench.sqlNotebook.textCellToolbar.changeTextCellView('Split View');
const sampleLabel = 'Microsoft';
const sampleAddress = 'https://www.microsoft.com';
await app.workbench.sqlNotebook.textCellToolbar.insertLink(sampleLabel, sampleAddress);
await app.code.dispatchKeybinding('escape');
await app.workbench.sqlNotebook.waitForTextCellPreviewContent(sampleLabel, `p a[href="${sampleAddress}"]`);
});
}); });
describe('markdown', function () { describe('markdown', function () {