mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-01-30 01:25:38 -05:00
PostgreSQL extension Accessibility issues (#16620)
* 1276734 * Set role to list * Pr changes * Set width to be a constant * Remove minwidth * Update button plugin * Fix operators * Pr
This commit is contained in:
@@ -29,7 +29,7 @@ export class ButtonColumn<T extends Slick.SlickData> extends BaseClickableColumn
|
||||
public get definition(): Slick.Column<T> {
|
||||
return {
|
||||
id: this.options.id || this.options.title || this.options.field,
|
||||
width: this.options.showText === true ? this.options.width : 26,
|
||||
width: this.options.width ?? 26,
|
||||
formatter: (row: number, cell: number, value: any, columnDef: Slick.Column<T>, dataContext: T): string => {
|
||||
const iconValue = getIconCellValue(this.options, dataContext);
|
||||
const escapedTitle = escape(iconValue.title ?? '');
|
||||
@@ -39,7 +39,7 @@ export class ButtonColumn<T extends Slick.SlickData> extends BaseClickableColumn
|
||||
return `<button tabindex=-1 class="${iconCssClasses} ${buttonTypeCssClass}" title="${escapedTitle}" aria-label="${escapedTitle}">${buttonText}</button>`;
|
||||
},
|
||||
name: this.options.name,
|
||||
resizable: this.options.showText === true, // Image only button has fixed width.
|
||||
resizable: this.options.resizable,
|
||||
selectable: false
|
||||
};
|
||||
}
|
||||
|
||||
@@ -201,6 +201,7 @@ export class OptionsDialog extends Modal {
|
||||
|
||||
let serviceOptions: azdata.ServiceOption[] = categoryMap[category];
|
||||
let bodyContainer = $('table.optionsDialog-table');
|
||||
bodyContainer.setAttribute('role', 'presentation');
|
||||
this.fillInOptions(bodyContainer, serviceOptions);
|
||||
append(this._optionGroupsContainer!, bodyContainer);
|
||||
}
|
||||
|
||||
@@ -34,6 +34,8 @@ import { IEditorProgressService } from 'vs/platform/progress/common/progress';
|
||||
import { IThemeService } from 'vs/platform/theme/common/themeService';
|
||||
|
||||
const ShowActionsText: string = nls.localize('dashboard.explorer.actions', "Show Actions");
|
||||
const LabelColoumnActions: string = nls.localize('dashboard.explorer.actionsColumn', "Actions");
|
||||
const ActionsColumnWidth: number = 50;
|
||||
const NameWithIconProperty: string = 'NameWithIcon';
|
||||
export const ConnectionProfilePropertyName: string = 'connection_profile';
|
||||
|
||||
@@ -72,7 +74,10 @@ export class ExplorerTable extends Disposable {
|
||||
this._actionsColumn = new ButtonColumn<Slick.SlickData>({
|
||||
id: 'actions',
|
||||
iconCssClass: 'toggle-more',
|
||||
title: ShowActionsText
|
||||
title: ShowActionsText,
|
||||
name: LabelColoumnActions,
|
||||
width: ActionsColumnWidth,
|
||||
resizable: false
|
||||
});
|
||||
this._table.registerPlugin(this._actionsColumn);
|
||||
this._register(this._actionsColumn.onClick((args) => {
|
||||
|
||||
Reference in New Issue
Block a user