ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

PostgreSQL extension Accessibility issues (#16620)

Browse Source 
* 1276734

* Set role to list

* Pr changes

* Set width to be  a constant

* Remove minwidth

* Update button plugin

* Fix operators

* Pr
This commit is contained in:
nasc17
2021-08-10 09:22:00 -07:00
committed by GitHub
parent a032426ac0
commit 7c9eaeea3c
3 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/base/browser/ui/table/plugins/buttonColumn.plugin.ts
View File

@@ -29,7 +29,7 @@ export class ButtonColumn<T extends Slick.SlickData> extends BaseClickableColumn
public get definition(): Slick.Column<T> { public get definition(): Slick.Column<T> {
return { return {
id: this.options.id || this.options.title || this.options.field, id: this.options.id || this.options.title || this.options.field,
width: this.options.showText === true ? this.options.width : 26, width: this.options.width ?? 26,
formatter: (row: number, cell: number, value: any, columnDef: Slick.Column<T>, dataContext: T): string => { formatter: (row: number, cell: number, value: any, columnDef: Slick.Column<T>, dataContext: T): string => {
const iconValue = getIconCellValue(this.options, dataContext); const iconValue = getIconCellValue(this.options, dataContext);
const escapedTitle = escape(iconValue.title ?? ''); const escapedTitle = escape(iconValue.title ?? '');
@@ -39,7 +39,7 @@ export class ButtonColumn<T extends Slick.SlickData> extends BaseClickableColumn
return `<button tabindex=-1 class="${iconCssClasses} ${buttonTypeCssClass}" title="${escapedTitle}" aria-label="${escapedTitle}">${buttonText}</button>`; return `<button tabindex=-1 class="${iconCssClasses} ${buttonTypeCssClass}" title="${escapedTitle}" aria-label="${escapedTitle}">${buttonText}</button>`;
}, },
name: this.options.name, name: this.options.name,
resizable: this.options.showText === true, // Image only button has fixed width. resizable: this.options.resizable,
selectable: false selectable: false
}; };
} }

1
src/sql/workbench/browser/modal/optionsDialog.ts
View File

@@ -201,6 +201,7 @@ export class OptionsDialog extends Modal {
let serviceOptions: azdata.ServiceOption[] = categoryMap[category]; let serviceOptions: azdata.ServiceOption[] = categoryMap[category];
let bodyContainer = $('table.optionsDialog-table'); let bodyContainer = $('table.optionsDialog-table');
bodyContainer.setAttribute('role', 'presentation');
this.fillInOptions(bodyContainer, serviceOptions); this.fillInOptions(bodyContainer, serviceOptions);
append(this._optionGroupsContainer!, bodyContainer); append(this._optionGroupsContainer!, bodyContainer);
} }

7
src/sql/workbench/contrib/dashboard/browser/widgets/explorer/explorerTable.ts
View File

@@ -34,6 +34,8 @@ import { IEditorProgressService } from 'vs/platform/progress/common/progress';
import { IThemeService } from 'vs/platform/theme/common/themeService'; import { IThemeService } from 'vs/platform/theme/common/themeService';
const ShowActionsText: string = nls.localize('dashboard.explorer.actions', "Show Actions"); const ShowActionsText: string = nls.localize('dashboard.explorer.actions', "Show Actions");
const LabelColoumnActions: string = nls.localize('dashboard.explorer.actionsColumn', "Actions");
const ActionsColumnWidth: number = 50;
const NameWithIconProperty: string = 'NameWithIcon'; const NameWithIconProperty: string = 'NameWithIcon';
export const ConnectionProfilePropertyName: string = 'connection_profile'; export const ConnectionProfilePropertyName: string = 'connection_profile';
@@ -72,7 +74,10 @@ export class ExplorerTable extends Disposable {
this._actionsColumn = new ButtonColumn<Slick.SlickData>({ this._actionsColumn = new ButtonColumn<Slick.SlickData>({
id: 'actions', id: 'actions',
iconCssClass: 'toggle-more', iconCssClass: 'toggle-more',
title: ShowActionsText title: ShowActionsText,
name: LabelColoumnActions,
width: ActionsColumnWidth,
resizable: false
}); });
this._table.registerPlugin(this._actionsColumn); this._table.registerPlugin(this._actionsColumn);
this._register(this._actionsColumn.onClick((args) => { this._register(this._actionsColumn.onClick((args) => {