ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

radio card change (#12049)

Browse Source 
* radio card change

* Clone the object

* freeze change description

* Change to deepClone
This commit is contained in:
Amir Omidi
2020-09-01 12:06:38 -07:00
committed by GitHub
parent 34e317a559
commit 7ceee95f52
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/resource-deployment/src/ui/resourceTypePickerDialog.ts
View File

@@ -83,7 +83,7 @@ export class ResourceTypePickerDialog extends DialogBase {
ariaLabel: localize('deploymentDialog.deploymentOptions', "Deployment options"), ariaLabel: localize('deploymentDialog.deploymentOptions', "Deployment options"),
width: '1100px' width: '1100px'
}).component(); }).component();
this._toDispose.push(this._cardGroup.onSelectionChanged((cardId: string) => { this._toDispose.push(this._cardGroup.onSelectionChanged(({ cardId }) => {
const resourceType = resourceTypes.find(rt => { return rt.name === cardId; }); const resourceType = resourceTypes.find(rt => { return rt.name === cardId; });
if (resourceType) { if (resourceType) {
this.selectResourceType(resourceType); this.selectResourceType(resourceType);

5
src/sql/azdata.proposed.d.ts vendored
View File

@@ -174,7 +174,10 @@ declare module 'azdata' {
} }
export interface RadioCardGroupComponent extends Component, RadioCardGroupComponentProperties { export interface RadioCardGroupComponent extends Component, RadioCardGroupComponentProperties {
onSelectionChanged: vscode.Event<any>; /**
* The card object returned from this function is a clone of the internal representation - changes will not impact the original object
*/
onSelectionChanged: vscode.Event<{ cardId: string; card?: RadioCard }>;
} }
export interface SeparatorComponent extends Component { export interface SeparatorComponent extends Component {

6
src/sql/workbench/browser/modelComponents/radioCardGroup.component.ts
View File

@@ -11,6 +11,7 @@ import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent';
import { KeyCode } from 'vs/base/common/keyCodes'; import { KeyCode } from 'vs/base/common/keyCodes';
import 'vs/css!./media/card'; import 'vs/css!./media/card';
import { IComponent, IComponentDescriptor, IModelStore, ComponentEventType } from 'sql/platform/dashboard/browser/interfaces'; import { IComponent, IComponentDescriptor, IModelStore, ComponentEventType } from 'sql/platform/dashboard/browser/interfaces';
import { deepClone } from 'vs/base/common/objects';
@Component({ @Component({
templateUrl: decodeURI(require.toUrl('./radioCardGroup.component.html')) templateUrl: decodeURI(require.toUrl('./radioCardGroup.component.html'))
@@ -141,7 +142,10 @@ export default class RadioCardGroup extends ComponentBase implements IComponent,
this._changeRef.detectChanges(); this._changeRef.detectChanges();
this.fireEvent({ this.fireEvent({
eventType: ComponentEventType.onDidChange, eventType: ComponentEventType.onDidChange,
args: cardId args: {
cardId,
card: deepClone(this.getCardById(cardId))
}
}); });
} }