From 7d5ce7b5d77c81a6667522bb8ecc88bc08879516 Mon Sep 17 00:00:00 2001
From: Kevin Cunnane <kcunnane@microsoft.com>
Date: Fri, 22 Feb 2019 18:06:00 -0800
Subject: [PATCH] Fix #4145 Possible for loading icon to appear with rendered
 widget (#4147)

- For cached insights, it was going down the checkStorage path which wasn't covered
---
 .../dashboard/widgets/insights/insightsWidget.component.ts     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/sql/parts/dashboard/widgets/insights/insightsWidget.component.ts b/src/sql/parts/dashboard/widgets/insights/insightsWidget.component.ts
index 5f465aa9ad..cc2a4a29ee 100644
--- a/src/sql/parts/dashboard/widgets/insights/insightsWidget.component.ts
+++ b/src/sql/parts/dashboard/widgets/insights/insightsWidget.component.ts
@@ -107,7 +107,7 @@ export class InsightsWidget extends DashboardWidget implements IDashboardWidget,
 								this.queryObv = Observable.fromPromise(TPromise.as<SimpleExecuteResult>(error));
 							}
 						}
-					);
+					).then(() => this._cd.detectChanges());
 				});
 				this._register(toDisposable(() => cancelablePromise.cancel()));
 			}
@@ -183,6 +183,7 @@ export class InsightsWidget extends DashboardWidget implements IDashboardWidget,
 				let storedResult: IStorageResult = JSON.parse(storage);
 				let date = new Date(storedResult.date);
 				this.lastUpdated = nls.localize('insights.lastUpdated', "Last Updated: {0} {1}", date.toLocaleTimeString(), date.toLocaleDateString());
+				this._loading = false;
 				if (this._init) {
 					this._updateChild(storedResult.results);
 					this.setupInterval();