ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Notebooks: Prevent Outputs from Rendering Too Many Times on Layout Change Events (#5366)

Browse Source 
* Prevent output rendering too many times

* went from 250ms to 50ms without any perf penalties
This commit is contained in:
Chris LaFreniere
2019-05-13 13:41:23 -07:00
committed by GitHub
parent 3ea45e4ef5
commit 7da0dddaa9
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/sql/workbench/parts/notebook/cellViews/output.component.ts
View File

@@ -7,6 +7,7 @@ import 'vs/css!./media/output';
import { OnInit, Component, Input, Inject, ElementRef, ViewChild, SimpleChange } from '@angular/core'; import { OnInit, Component, Input, Inject, ElementRef, ViewChild, SimpleChange } from '@angular/core';
import { AngularDisposable } from 'sql/base/node/lifecycle'; import { AngularDisposable } from 'sql/base/node/lifecycle';
import { Event } from 'vs/base/common/event';
import { nb } from 'azdata'; import { nb } from 'azdata';
import { ICellModel } from 'sql/workbench/parts/notebook/models/modelInterfaces'; import { ICellModel } from 'sql/workbench/parts/notebook/models/modelInterfaces';
import { INotebookService } from 'sql/workbench/services/notebook/common/notebookService'; import { INotebookService } from 'sql/workbench/services/notebook/common/notebookService';
@@ -29,7 +30,6 @@ export class OutputComponent extends AngularDisposable implements OnInit {
@Input() cellModel: ICellModel; @Input() cellModel: ICellModel;
private _trusted: boolean; private _trusted: boolean;
private _initialized: boolean = false; private _initialized: boolean = false;
private readonly _minimumHeight = 30;
private _activeCellId: string; private _activeCellId: string;
registry: RenderMimeRegistry; registry: RenderMimeRegistry;
@@ -45,9 +45,8 @@ export class OutputComponent extends AngularDisposable implements OnInit {
ngOnInit() { ngOnInit() {
this.renderOutput(); this.renderOutput();
this._initialized = true; this._initialized = true;
this.cellModel.notebookModel.layoutChanged(() => { this._register(Event.debounce(this.cellModel.notebookModel.layoutChanged, (l, e) => e, 50, /*leading=*/false)
this.renderOutput(); (() => this.renderOutput()));
});
} }
ngOnChanges(changes: { [propKey: string]: SimpleChange }) { ngOnChanges(changes: { [propKey: string]: SimpleChange }) {
@@ -72,12 +71,10 @@ export class OutputComponent extends AngularDisposable implements OnInit {
} }
private renderOutput() { private renderOutput() {
let node = this.outputElement.nativeElement; let options = outputProcessor.getBundleOptions({ value: this.cellOutput, trusted: this.trustedMode });
let output = this.cellOutput;
let options = outputProcessor.getBundleOptions({ value: output, trusted: this.trustedMode });
options.themeService = this._themeService; options.themeService = this._themeService;
// TODO handle safe/unsafe mapping // TODO handle safe/unsafe mapping
this.createRenderedMimetype(options, node); this.createRenderedMimetype(options, this.outputElement.nativeElement);
} }
public layout(): void { public layout(): void {