From 7dca9536600dd31ea5b1596d66243794654d3b28 Mon Sep 17 00:00:00 2001 From: Alan Ren Date: Fri, 7 May 2021 18:57:22 -0700 Subject: [PATCH] fix line number display issue (#15368) --- src/sql/workbench/services/query/common/queryRunner.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/sql/workbench/services/query/common/queryRunner.ts b/src/sql/workbench/services/query/common/queryRunner.ts index 7f464b6cac..7aa10f10de 100644 --- a/src/sql/workbench/services/query/common/queryRunner.ts +++ b/src/sql/workbench/services/query/common/queryRunner.ts @@ -174,8 +174,9 @@ export default class QueryRunner extends Disposable { this._messages = []; if (isRangeOrUndefined(input)) { // Update internal state to show that we're executing the query - this._resultLineOffset = input ? input.startLineNumber : 0; - this._resultColumnOffset = input ? input.startColumn : 0; + // startLineNumber/startColumn is 1 based, need to do a -1 to get the offset. + this._resultLineOffset = input ? (input.startLineNumber - 1) : 0; + this._resultColumnOffset = input ? (input.startColumn - 1) : 0; this._isExecuting = true; this._totalElapsedMilliseconds = 0; // TODO issue #228 add statusview callbacks here