Try to make smoke tests more stable (#15212)

* make sure dialog buttons are not disabled

* use 'enter' to close connect dialog

* retry clikcing the Connect button

* wait for dialog gone after reclicking

* pr comments + add logging

* use debug to log

* close toasts before clicking dialog buttons

* await close notification toast call

* click python wizard buttons instead of enter
This commit is contained in:
Lucy Zhang
2021-04-27 16:53:17 -04:00
committed by GitHub
parent c66a8ca171
commit 7e1c0076ba
6 changed files with 61 additions and 9 deletions

View File

@@ -28,6 +28,7 @@ import { QueryEditors } from './sql/queryEditors';
import { QueryEditor } from './sql/queryEditor';
import { Notebook as SqlNotebook } from './sql/notebook';
import { ConfigurePythonDialog } from './sql/configurePythonDialog';
import { NotificationToast } from './sql/notificationToast';
// {{END}}
export interface Commands {
@@ -60,6 +61,7 @@ export class Workbench {
readonly queryEditor: QueryEditor;
readonly sqlNotebook: SqlNotebook;
readonly configurePythonDialog: ConfigurePythonDialog;
readonly notificationToast: NotificationToast;
// {{END}}
constructor(code: Code, userDataPath: string) {
@@ -79,12 +81,13 @@ export class Workbench {
this.keybindingsEditor = new KeybindingsEditor(code);
this.terminal = new Terminal(code, this.quickaccess);
// {{SQL CARBON EDIT}}
this.connectionDialog = new ConnectionDialog(code);
this.notificationToast = new NotificationToast(code);
this.connectionDialog = new ConnectionDialog(code, this.notificationToast);
this.profiler = new Profiler(code, this.quickaccess);
this.queryEditors = new QueryEditors(code, this.editors);
this.queryEditor = new QueryEditor(code);
this.sqlNotebook = new SqlNotebook(code, this.quickaccess, this.quickinput, this.editors);
this.configurePythonDialog = new ConfigurePythonDialog(code);
this.configurePythonDialog = new ConfigurePythonDialog(code, this.notificationToast);
// {{END}}
this.notebook = new Notebook(this.quickaccess, code);
}