mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-02-09 17:52:34 -05:00
Merge from vscode 52dcb723a39ae75bee1bd56b3312d7fcdc87aeed (#6719)
This commit is contained in:
@@ -5,7 +5,7 @@
|
||||
|
||||
import 'vs/css!./contextview';
|
||||
import * as DOM from 'vs/base/browser/dom';
|
||||
import { IDisposable, dispose, toDisposable, Disposable, DisposableStore } from 'vs/base/common/lifecycle';
|
||||
import { IDisposable, toDisposable, Disposable, DisposableStore } from 'vs/base/common/lifecycle';
|
||||
import { Range } from 'vs/base/common/range';
|
||||
|
||||
export interface IAnchor {
|
||||
@@ -100,11 +100,11 @@ export class ContextView extends Disposable {
|
||||
private static readonly BUBBLE_UP_EVENTS = ['click', 'keydown', 'focus', 'blur'];
|
||||
private static readonly BUBBLE_DOWN_EVENTS = ['click'];
|
||||
|
||||
private container: HTMLElement | null;
|
||||
private container: HTMLElement | null = null;
|
||||
private view: HTMLElement;
|
||||
private delegate: IDelegate | null;
|
||||
private toDisposeOnClean: IDisposable | null;
|
||||
private toDisposeOnSetContainer: IDisposable;
|
||||
private delegate: IDelegate | null = null;
|
||||
private toDisposeOnClean: IDisposable = Disposable.None;
|
||||
private toDisposeOnSetContainer: IDisposable = Disposable.None;
|
||||
|
||||
constructor(container: HTMLElement) {
|
||||
super();
|
||||
@@ -120,7 +120,7 @@ export class ContextView extends Disposable {
|
||||
|
||||
setContainer(container: HTMLElement | null): void {
|
||||
if (this.container) {
|
||||
dispose(this.toDisposeOnSetContainer);
|
||||
this.toDisposeOnSetContainer.dispose();
|
||||
this.container.removeChild(this.view);
|
||||
this.container = null;
|
||||
}
|
||||
@@ -159,7 +159,7 @@ export class ContextView extends Disposable {
|
||||
DOM.show(this.view);
|
||||
|
||||
// Render content
|
||||
this.toDisposeOnClean = delegate.render(this.view);
|
||||
this.toDisposeOnClean = delegate.render(this.view) || Disposable.None;
|
||||
|
||||
// Set active delegate
|
||||
this.delegate = delegate;
|
||||
@@ -267,10 +267,7 @@ export class ContextView extends Disposable {
|
||||
delegate.onHide(data);
|
||||
}
|
||||
|
||||
if (this.toDisposeOnClean) {
|
||||
this.toDisposeOnClean.dispose();
|
||||
this.toDisposeOnClean = null;
|
||||
}
|
||||
this.toDisposeOnClean.dispose();
|
||||
|
||||
DOM.hide(this.view);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user