From 7ec08997842386dc09fbd2bc4bbe9091d0b19a43 Mon Sep 17 00:00:00 2001 From: Kim Santiago <31145923+kisantia@users.noreply.github.com> Date: Tue, 22 Aug 2023 10:53:43 -0700 Subject: [PATCH] announce when extension install is finished (#24179) --- .../contrib/extensions/browser/extensionsActions.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/extensions/browser/extensionsActions.ts b/src/vs/workbench/contrib/extensions/browser/extensionsActions.ts index bfeb66dbdf..2062d1cd30 100644 --- a/src/vs/workbench/contrib/extensions/browser/extensionsActions.ts +++ b/src/vs/workbench/contrib/extensions/browser/extensionsActions.ts @@ -432,8 +432,12 @@ export abstract class AbstractInstallAction extends ExtensionAction { const extension = await this.install(this.extension); - if (extension && extension?.local) { + // {{SQL CARBON EDIT}} Announce extension is finished being installed even if extension.local is undefined + if (extension) { alert(localize('installExtensionComplete', "Installing extension {0} is completed.", this.extension.displayName)); + } + + if (extension && (extension?.local)) { const runningExtension = await this.getRunningExtension(extension.local); if (runningExtension && !(runningExtension.activationEvents && runningExtension.activationEvents.some(activationEent => activationEent.startsWith('onLanguage')))) { const action = await this.getThemeAction(extension);