ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixing setTargetServerName in SqlMigration extension. Previously if a case was entered it would run all code in the following cases as well (#22477)

Browse Source
This commit is contained in:
Austin Bryan
2023-03-29 13:44:29 -07:00
committed by GitHub
parent 4867a3747c
commit 7ecbbdf398
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/sql-migration/src/models/stateMachine.ts
View File

@@ -1328,14 +1328,17 @@ export class MigrationStateModel implements Model, vscode.Disposable {
case MigrationTargetType.SQLMI: case MigrationTargetType.SQLMI:
const sqlMi = this._targetServerInstance as SqlManagedInstance; const sqlMi = this._targetServerInstance as SqlManagedInstance;
this._targetServerName = sqlMi.properties.fullyQualifiedDomainName; this._targetServerName = sqlMi.properties.fullyQualifiedDomainName;
break;
case MigrationTargetType.SQLDB: case MigrationTargetType.SQLDB:
const sqlDb = this._targetServerInstance as AzureSqlDatabaseServer; const sqlDb = this._targetServerInstance as AzureSqlDatabaseServer;
this._targetServerName = sqlDb.properties.fullyQualifiedDomainName; this._targetServerName = sqlDb.properties.fullyQualifiedDomainName;
break;
case MigrationTargetType.SQLVM: case MigrationTargetType.SQLVM:
// For sqlvm, we need to use ip address from the network interface to connect to the server // For sqlvm, we need to use ip address from the network interface to connect to the server
const sqlVm = this._targetServerInstance as SqlVMServer; const sqlVm = this._targetServerInstance as SqlVMServer;
const networkInterfaces = Array.from(sqlVm.networkInterfaces.values()); const networkInterfaces = Array.from(sqlVm.networkInterfaces.values());
this._targetServerName = NetworkInterfaceModel.getIpAddress(networkInterfaces); this._targetServerName = NetworkInterfaceModel.getIpAddress(networkInterfaces);
break;
} }
} }