Clean up some of the extensions (#8267)

* 💄

* prune unused code

* more cleanup

* remove abunch of used code

extensions/mssql/src/objectExplorerNodeProvider/command.ts

@@ -15,12 +15,12 @@ import * as utils from '../utils';
 import * as constants from '../constants';
 import { AppContext } from '../appContext';
 
-export interface ICommandContextParsingOptions {
+interface ICommandContextParsingOptions {
 	editor: boolean;
 	uri: boolean;
 }
 
-export interface ICommandBaseContext {
+interface ICommandBaseContext {
 	command: string;
 	editor?: vscode.TextEditor;
 	uri?: vscode.Uri;
@@ -30,7 +30,7 @@ export interface ICommandUnknownContext extends ICommandBaseContext {
 	type: 'unknown';
 }
 
-export interface ICommandUriContext extends ICommandBaseContext {
+interface ICommandUriContext extends ICommandBaseContext {
 	type: 'uri';
 }
 
@@ -44,7 +44,7 @@ export interface ICommandObjectExplorerContext extends ICommandBaseContext {
 	explorerContext: azdata.ObjectExplorerContext;
 }
 
-export type CommandContext = ICommandObjectExplorerContext | ICommandViewContext | ICommandUriContext | ICommandUnknownContext;
+type CommandContext = ICommandObjectExplorerContext | ICommandViewContext | ICommandUriContext | ICommandUnknownContext;
 
 function isTextEditor(editor: any): editor is vscode.TextEditor {
 	if (editor === undefined) { return false; }
@@ -189,4 +189,4 @@ export function registerSearchServerCommand(appContext: AppContext): void {
 	appContext.apiWrapper.registerCommand('mssql.clearSearchServerResult', () => {
 		vscode.commands.executeCommand('registeredServers.clearSearchServerResult');
 	});
-}
+}

extensions/mssql/src/objectExplorerNodeProvider/fileSources.ts

@@ -106,10 +106,11 @@ export interface IFileSource {
 	exists(path: string): Promise<boolean>;
 }
 
-export interface IHttpAuthentication {
+interface IHttpAuthentication {
 	user: string;
 	pass: string;
 }
+
 export interface IHdfsOptions {
 	host?: string;
 	port?: number;
@@ -176,7 +177,7 @@ export class FileSourceFactory {
 	}
 }
 
-export class HdfsFileSource implements IFileSource {
+class HdfsFileSource implements IFileSource {
 	private mounts: Map<string, Mount>;
 	constructor(private client: WebHDFS) {
 	}
@@ -240,7 +241,7 @@ export class HdfsFileSource implements IFileSource {
 	public readFile(path: string, maxBytes?: number): Promise<Buffer> {
 		return new Promise((resolve, reject) => {
 			let error: HdfsError = undefined;
-			let remoteFileStream = this.client.createReadStream(path);
+			let remoteFileStream: fs.ReadStream | meter.StreamMeter = this.client.createReadStream(path);
 			remoteFileStream.on('error', (err) => {
 				error = <HdfsError>err;
 				reject(error);

extensions/mssql/src/objectExplorerNodeProvider/hdfsCommands.ts

@@ -71,8 +71,8 @@ export class UploadFilesCommand extends ProgressCommand {
 		try {
 			let folderNode = await getNode<FolderNode>(context, this.appContext);
 			const allFilesFilter = localize('allFiles', "All Files");
-			let filter = {};
-			filter[allFilesFilter] = '*';
+			let filter: { [key: string]: string[] } = {};
+			filter[allFilesFilter] = ['*'];
 			if (folderNode) {
 				let options: vscode.OpenDialogOptions = {
 					canSelectFiles: true,
@@ -175,7 +175,7 @@ export class MkDirCommand extends ProgressCommand {
 		}).then(confirmed => <string>confirmed);
 	}
 
-	private async mkDir(fileName, folderNode: FolderNode, cancelToken: vscode.CancellationTokenSource): Promise<void> {
+	private async mkDir(fileName: string, folderNode: FolderNode, cancelToken: vscode.CancellationTokenSource): Promise<void> {
 		await folderNode.mkdir(fileName);
 	}
 }

extensions/mssql/src/objectExplorerNodeProvider/hdfsProvider.ts

@@ -11,7 +11,7 @@ import * as nls from 'vscode-nls';
 const localize = nls.loadMessageBundle();
 
 import * as Constants from '../constants';
-import { IFileSource, IHdfsOptions, IFile, File, FileSourceFactory, FileType } from './fileSources';
+import { IFileSource, IFile, File, FileType } from './fileSources';
 import { CancelableStream } from './cancelableStream';
 import { TreeNode } from './treeNodes';
 import * as utils from '../utils';
@@ -28,53 +28,6 @@ export class TreeDataContext {
 	}
 }
 
-export class HdfsProvider implements vscode.TreeDataProvider<TreeNode>, ITreeChangeHandler {
-	static readonly NoConnectionsMessage = 'No connections added';
-	static readonly ConnectionsLabel = 'Connections';
-
-	private connections: ConnectionNode[];
-	private _onDidChangeTreeData = new vscode.EventEmitter<TreeNode>();
-	private context: TreeDataContext;
-
-	constructor(extensionContext: vscode.ExtensionContext) {
-		this.connections = [];
-		this.context = new TreeDataContext(extensionContext, this);
-	}
-
-	public get onDidChangeTreeData(): vscode.Event<TreeNode> {
-		return this._onDidChangeTreeData.event;
-	}
-
-	getTreeItem(element: TreeNode): vscode.TreeItem | Thenable<vscode.TreeItem> {
-		return element.getTreeItem();
-	}
-
-	getChildren(element?: TreeNode): vscode.ProviderResult<TreeNode[]> {
-		if (element) {
-			return element.getChildren(false);
-		} else {
-			return this.connections.length > 0 ? this.connections : [ErrorNode.create(HdfsProvider.NoConnectionsMessage, element)];
-		}
-	}
-
-	addConnection(displayName: string, fileSource: IFileSource): void {
-		if (!this.connections.find(c => c.getDisplayName() === displayName)) {
-			this.connections.push(new ConnectionNode(this.context, displayName, fileSource));
-			this._onDidChangeTreeData.fire();
-		}
-	}
-
-	public async addHdfsConnection(options: IHdfsOptions): Promise<void> {
-		let displayName = `${options.user}@${options.host}:${options.port}`;
-		let fileSource = await FileSourceFactory.instance.createHdfsFileSource(options);
-		this.addConnection(displayName, fileSource);
-	}
-
-	notifyNodeChanged(node: TreeNode): void {
-		this._onDidChangeTreeData.fire(node);
-	}
-}
-
 export abstract class HdfsFileSourceNode extends TreeNode {
 	constructor(protected context: TreeDataContext, protected _path: string, public readonly fileSource: IFileSource, protected mountStatus?: MountStatus) {
 		super();
@@ -362,7 +315,7 @@ export class FileNode extends HdfsFileSourceNode implements IFileNode {
 	}
 }
 
-export class ErrorNode extends TreeNode {
+class ErrorNode extends TreeNode {
 	static messageNum: number = 0;
 
 	private _nodePathValue: string;

extensions/mssql/src/objectExplorerNodeProvider/objectExplorerNodeProvider.ts

@@ -3,8 +3,6 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import * as azdata from 'azdata';
 import * as vscode from 'vscode';
 import * as nls from 'vscode-nls';
@@ -72,7 +70,7 @@ export class MssqlObjectExplorerNodeProvider extends ProviderBase implements azd
 
 	private async doExpandNode(nodeInfo: azdata.ExpandNodeInfo, isRefresh: boolean = false): Promise<boolean> {
 		let session = this.sessionMap.get(nodeInfo.sessionId);
-		let response = {
+		let response: azdata.ObjectExplorerExpandInfo = {
 			sessionId: nodeInfo.sessionId,
 			nodePath: nodeInfo.nodePath,
 			errorMessage: undefined,
@@ -235,7 +233,7 @@ export class MssqlObjectExplorerNodeProvider extends ProviderBase implements azd
 	}
 }
 
-export class SqlClusterSession {
+class SqlClusterSession {
 	private _rootNode: SqlClusterRootNode;
 
 	constructor(