From 7fb8a28b5953d124de97852bc299950d09ad9c85 Mon Sep 17 00:00:00 2001
From: Anthony Dresser <andresse@microsoft.com>
Date: Mon, 23 Apr 2018 17:41:24 -0700
Subject: [PATCH] properties isn't scrolling (#1225)

---
 .../dashboardHomeContainer.component.ts        | 18 ++++++++----------
 .../dashboardWidgetContainer.component.ts      |  8 ++++----
 2 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/src/sql/parts/dashboard/containers/dashboardHomeContainer.component.ts b/src/sql/parts/dashboard/containers/dashboardHomeContainer.component.ts
index 959a7e21a3..2685243ae1 100644
--- a/src/sql/parts/dashboard/containers/dashboardHomeContainer.component.ts
+++ b/src/sql/parts/dashboard/containers/dashboardHomeContainer.component.ts
@@ -20,26 +20,24 @@ import { ConfigurationTarget } from 'vs/platform/configuration/common/configurat
 	selector: 'dashboard-home-container',
 	providers: [{ provide: DashboardTab, useExisting: forwardRef(() => DashboardHomeContainer) }],
 	template: `
-		<dashboard-widget-wrapper #propertiesClass *ngIf="properties" [collapsable]="true" [_config]="properties"
-			style="padding-left: 10px; padding-right: 10px; display: block" [style.height.px]="_propertiesClass?.collapsed ? '30' : '90'">
-		</dashboard-widget-wrapper>
-		<widget-content [widgets]="widgets" [originalConfig]="tab.originalConfig" [context]="tab.context">
-		</widget-content>
+		<div class="fullsize" style="display: flex; flex-direction: column">
+			<dashboard-widget-wrapper #propertiesClass *ngIf="properties" [collapsable]="true" [_config]="properties"
+				style="padding-left: 10px; padding-right: 10px; display: block; flex: 0" [style.height.px]="_propertiesClass?.collapsed ? '30' : '90'">
+			</dashboard-widget-wrapper>
+			<widget-content style="flex: 1" [widgets]="widgets" [originalConfig]="tab.originalConfig" [context]="tab.context">
+			</widget-content>
+		</div>
 	`
 })
 export class DashboardHomeContainer extends DashboardWidgetContainer {
 	@Input() private properties: WidgetConfig;
 	@ViewChild('propertiesClass') private _propertiesClass: DashboardWidgetWrapper;
 
-	private dashboardService: DashboardServiceInterface;
-
 	constructor(
 		@Inject(forwardRef(() => ChangeDetectorRef)) _cd: ChangeDetectorRef,
-		@Inject(forwardRef(() => CommonServiceInterface)) protected commonService: CommonServiceInterface,
-
+		@Inject(forwardRef(() => CommonServiceInterface)) protected dashboardService: DashboardServiceInterface
 	) {
 		super(_cd);
-		this.dashboardService = commonService as DashboardServiceInterface;
 	}
 
 	ngAfterContentInit() {
diff --git a/src/sql/parts/dashboard/containers/dashboardWidgetContainer.component.ts b/src/sql/parts/dashboard/containers/dashboardWidgetContainer.component.ts
index 3cc029eedf..49ae19d4d4 100644
--- a/src/sql/parts/dashboard/containers/dashboardWidgetContainer.component.ts
+++ b/src/sql/parts/dashboard/containers/dashboardWidgetContainer.component.ts
@@ -28,9 +28,9 @@ import Event, { Emitter } from 'vs/base/common/event';
 		</widget-content>
 	`
 })
-export class DashboardWidgetContainer extends DashboardTab implements OnDestroy, OnChanges, AfterContentInit {
-	@Input() private tab: TabConfig;
-	private widgets: WidgetConfig[];
+export class DashboardWidgetContainer extends DashboardTab implements OnDestroy, AfterContentInit {
+	@Input() protected tab: TabConfig;
+	protected widgets: WidgetConfig[];
 	private _onResize = new Emitter<void>();
 	public readonly onResize: Event<void> = this._onResize.event;
 
@@ -42,7 +42,7 @@ export class DashboardWidgetContainer extends DashboardTab implements OnDestroy,
 		super();
 	}
 
-	ngOnChanges() {
+	ngOnInit() {
 		if (this.tab.container) {
 			this.widgets = Object.values(this.tab.container)[0];
 			this._cd.detectChanges();