ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix drag-n-drop null ref in OE (#2163)

Browse Source
This commit is contained in:
Karl Burtram
2018-08-07 13:57:59 -04:00
committed by GitHub
parent fba8536c33
commit 807f8e68f3
1 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/sql/parts/objectExplorer/viewlet/dragAndDropController.ts
View File

@@ -96,24 +96,24 @@ export class ServerTreeDragAndDrop implements IDragAndDrop {
let targetConnectionProfileGroup: ConnectionProfileGroup = this.getTargetGroup(targetElement); let targetConnectionProfileGroup: ConnectionProfileGroup = this.getTargetGroup(targetElement);
const source = data.getData()[0]; const source = data.getData()[0];
let oldParent: ConnectionProfileGroup = source.getParent(); if (source && source.getParent) {
const self = this; let oldParent: ConnectionProfileGroup = source.getParent();
if (this.isDropAllowed(targetConnectionProfileGroup, oldParent, source)) { const self = this;
if (this.isDropAllowed(targetConnectionProfileGroup, oldParent, source)) {
if (source instanceof ConnectionProfile) { if (source instanceof ConnectionProfile) {
// Change group id of profile // Change group id of profile
this._connectionManagementService.changeGroupIdForConnection(source, targetConnectionProfileGroup.id).then(() => { this._connectionManagementService.changeGroupIdForConnection(source, targetConnectionProfileGroup.id).then(() => {
TreeUpdateUtils.registeredServerUpdate(tree, self._connectionManagementService, targetConnectionProfileGroup); TreeUpdateUtils.registeredServerUpdate(tree, self._connectionManagementService, targetConnectionProfileGroup);
}); });
} else if (source instanceof ConnectionProfileGroup) { } else if (source instanceof ConnectionProfileGroup) {
// Change parent id of group // Change parent id of group
this._connectionManagementService.changeGroupIdForConnectionGroup(source, targetConnectionProfileGroup).then(() => { this._connectionManagementService.changeGroupIdForConnectionGroup(source, targetConnectionProfileGroup).then(() => {
TreeUpdateUtils.registeredServerUpdate(tree, self._connectionManagementService); TreeUpdateUtils.registeredServerUpdate(tree, self._connectionManagementService);
}); });
}
} }
} }
return;
} }
public dropAbort(tree: ITree, data: IDragAndDropData): void { public dropAbort(tree: ITree, data: IDragAndDropData): void {