From 80bdc3d6be8f1e6cadfc3ead5afcdee0223aa4da Mon Sep 17 00:00:00 2001 From: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com> Date: Thu, 13 Oct 2022 17:00:51 -0700 Subject: [PATCH] Remove deprecated "Asynchronous Processing" connection property (#20830) --- extensions/cms/package.json | 14 -------------- extensions/cms/package.nls.json | 2 -- extensions/mssql/package.json | 14 -------------- extensions/mssql/package.nls.json | 2 -- resources/xlf/en/cms.xlf | 8 +------- resources/xlf/en/mssql.xlf | 8 +------- .../test/browser/modal/optionsDialogHelper.test.ts | 10 +++++----- 7 files changed, 7 insertions(+), 51 deletions(-) diff --git a/extensions/cms/package.json b/extensions/cms/package.json index 4a2fd6d064..dc732c5249 100644 --- a/extensions/cms/package.json +++ b/extensions/cms/package.json @@ -165,20 +165,6 @@ "isRequired": false, "isArray": false }, - { - "specialValueType": null, - "isIdentity": false, - "name": "asynchronousProcessing", - "displayName": "%cms.connectionOptions.asynchronousProcessing.displayName%", - "description": "%cms.connectionOptions.asynchronousProcessing.description%", - "groupName": "%cms.connectionOptions.groupName.initialization%", - "valueType": "boolean", - "defaultValue": null, - "objectType": null, - "categoryValues": null, - "isRequired": false, - "isArray": false - }, { "specialValueType": null, "isIdentity": false, diff --git a/extensions/cms/package.nls.json b/extensions/cms/package.nls.json index 4de5381cf8..a94ae0d678 100644 --- a/extensions/cms/package.nls.json +++ b/extensions/cms/package.nls.json @@ -60,8 +60,6 @@ "cms.connectionOptions.password.description": "Indicates the password to be used when connecting to the data source", "cms.connectionOptions.applicationIntent.displayName": "Application intent", "cms.connectionOptions.applicationIntent.description": "Declares the application workload type when connecting to a server", - "cms.connectionOptions.asynchronousProcessing.displayName": "Asynchronous processing", - "cms.connectionOptions.asynchronousProcessing.description": "When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider", "cms.connectionOptions.connectTimeout.displayName": "Connect timeout", "cms.connectionOptions.connectTimeout.description": "The length of time (in seconds) to wait for a connection to the server before terminating the attempt and generating an error", "cms.connectionOptions.currentLanguage.displayName": "Current language", diff --git a/extensions/mssql/package.json b/extensions/mssql/package.json index 8a192b3444..68d0fe46df 100644 --- a/extensions/mssql/package.json +++ b/extensions/mssql/package.json @@ -946,20 +946,6 @@ "isRequired": false, "isArray": false }, - { - "specialValueType": null, - "isIdentity": false, - "name": "asynchronousProcessing", - "displayName": "%mssql.connectionOptions.asynchronousProcessing.displayName%", - "description": "%mssql.connectionOptions.asynchronousProcessing.description%", - "groupName": "%mssql.connectionOptions.groupName.initialization%", - "valueType": "boolean", - "defaultValue": null, - "objectType": null, - "categoryValues": null, - "isRequired": false, - "isArray": false - }, { "specialValueType": null, "isIdentity": false, diff --git a/extensions/mssql/package.nls.json b/extensions/mssql/package.nls.json index 8c7d32fe5c..016378595a 100644 --- a/extensions/mssql/package.nls.json +++ b/extensions/mssql/package.nls.json @@ -127,8 +127,6 @@ "mssql.connectionOptions.password.description": "Indicates the password to be used when connecting to the data source", "mssql.connectionOptions.applicationIntent.displayName": "Application intent", "mssql.connectionOptions.applicationIntent.description": "Declares the application workload type when connecting to a server", - "mssql.connectionOptions.asynchronousProcessing.displayName": "Asynchronous processing", - "mssql.connectionOptions.asynchronousProcessing.description": "When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider", "mssql.connectionOptions.connectTimeout.displayName": "Connect timeout", "mssql.connectionOptions.connectTimeout.description": "The length of time (in seconds) to wait for a connection to the server before terminating the attempt and generating an error", "mssql.connectionOptions.currentLanguage.displayName": "Current language", diff --git a/resources/xlf/en/cms.xlf b/resources/xlf/en/cms.xlf index 4b1673e08c..e81bc04802 100644 --- a/resources/xlf/en/cms.xlf +++ b/resources/xlf/en/cms.xlf @@ -95,12 +95,6 @@ Application name - - When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider - - - Asynchronous processing - Attach DB filename @@ -402,4 +396,4 @@ Version - \ No newline at end of file + diff --git a/resources/xlf/en/mssql.xlf b/resources/xlf/en/mssql.xlf index 8be35a2899..e10f365e2e 100644 --- a/resources/xlf/en/mssql.xlf +++ b/resources/xlf/en/mssql.xlf @@ -724,12 +724,6 @@ Application name - - When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider - - - Asynchronous processing - Attach DB filename @@ -1224,4 +1218,4 @@ Dashboard Tasks - \ No newline at end of file + diff --git a/src/sql/workbench/test/browser/modal/optionsDialogHelper.test.ts b/src/sql/workbench/test/browser/modal/optionsDialogHelper.test.ts index 23a9ba37cd..4e88528153 100644 --- a/src/sql/workbench/test/browser/modal/optionsDialogHelper.test.ts +++ b/src/sql/workbench/test/browser/modal/optionsDialogHelper.test.ts @@ -47,9 +47,9 @@ suite('Advanced options helper tests', () => { }; booleanOption = { - name: 'asynchronousProcessing', - displayName: 'Asynchronous processing enabled', - description: 'When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider', + name: 'trustServerCertificate', + displayName: 'Trust Server Certificate enabled', + description: 'When true (and encrypt=true), SQL Server uses SSL encryption for all data sent between the client and server without validating the server certificate', groupName: 'Initialization', categoryValues: null, defaultValue: null, @@ -228,7 +228,7 @@ suite('Advanced options helper tests', () => { booleanOption.defaultValue = null; booleanOption.isRequired = false; possibleInputs = []; - options['asynchronousProcessing'] = true; + options['trustServerCertificate'] = true; let optionValue = OptionsDialogHelper.getOptionValueAndCategoryValues(booleanOption, options, possibleInputs); assert.strictEqual(optionValue, 'True'); assert.strictEqual(possibleInputs.length, 3); @@ -241,7 +241,7 @@ suite('Advanced options helper tests', () => { booleanOption.defaultValue = null; booleanOption.isRequired = true; possibleInputs = []; - options['asynchronousProcessing'] = 'False'; + options['trustServerCertificate'] = 'False'; let optionValue = OptionsDialogHelper.getOptionValueAndCategoryValues(booleanOption, options, possibleInputs); assert.strictEqual(optionValue, 'False'); assert.strictEqual(possibleInputs.length, 2);