From 8166c8eeda90a7ebbde1647a5308c71c23aa702a Mon Sep 17 00:00:00 2001 From: Aasim Khan Date: Mon, 31 Jul 2023 13:36:37 -0700 Subject: [PATCH] Commenting out listener threshold to fix extensions having mem leaks registering more listeners. (#24012) (#24024) * Commenting out listener threshold * Adding SQL carbon edit --- src/vs/base/common/event.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/vs/base/common/event.ts b/src/vs/base/common/event.ts index 92dc7c4e50..b6a178c82b 100644 --- a/src/vs/base/common/event.ts +++ b/src/vs/base/common/event.ts @@ -947,10 +947,11 @@ export class Emitter { this._listeners = new LinkedList(); } - if (this._leakageMon && this._listeners.size > this._leakageMon.threshold * 3) { - console.warn(`[${this._leakageMon.name}] REFUSES to accept new listeners because it exceeded its threshold by far`); - return Disposable.None; - } + // {{SQL CARBON EDIT}} Disabling threshold to unblock model view components to register more listeners. Due to the threshold, the components were not able to register listeners and were not able to handle click events. + // if (this._leakageMon && this._listeners.size > this._leakageMon.threshold * 3) { + // console.warn(`[${this._leakageMon.name}] REFUSES to accept new listeners because it exceeded its threshold by far`); + // return Disposable.None; + // } const firstListener = this._listeners.isEmpty();