From 81ae52f75f34fa973d456cb42a2055cc5ff82557 Mon Sep 17 00:00:00 2001 From: v-bbrady <60623315+v-bbrady@users.noreply.github.com> Date: Mon, 20 Apr 2020 20:48:28 -0700 Subject: [PATCH] Bbrady/release port/fixes video and admin pack images (#10053) * merge cherry picked changes * merges cherry picked commit --- .../welcome/media/extension_pack_img.svg | 42 +++++++++++++++++++ .../page/browser/az_data_welcome_page.ts | 4 +- .../welcome/page/browser/welcomePage.css | 2 +- .../welcome/page/browser/welcomePage.ts | 9 ---- 4 files changed, 45 insertions(+), 12 deletions(-) create mode 100644 src/sql/workbench/contrib/welcome/media/extension_pack_img.svg diff --git a/src/sql/workbench/contrib/welcome/media/extension_pack_img.svg b/src/sql/workbench/contrib/welcome/media/extension_pack_img.svg new file mode 100644 index 0000000000..d10e1277e1 --- /dev/null +++ b/src/sql/workbench/contrib/welcome/media/extension_pack_img.svg @@ -0,0 +1,42 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/src/sql/workbench/contrib/welcome/page/browser/az_data_welcome_page.ts b/src/sql/workbench/contrib/welcome/page/browser/az_data_welcome_page.ts index e6ea2e568d..b076c694f6 100644 --- a/src/sql/workbench/contrib/welcome/page/browser/az_data_welcome_page.ts +++ b/src/sql/workbench/contrib/welcome/page/browser/az_data_welcome_page.ts @@ -165,7 +165,7 @@ export default () => `
- +

${escape(localize('welcomePage.videoDescriptionOverview', "Overview of Azure Data Studio"))}

 @@ -173,7 +173,7 @@ export default () => `
- +

${escape(localize('welcomePage.videoDescriptionIntroduction', "Introduction to Azure Data Studio Notebooks | Data Exposed"))}

 diff --git a/src/sql/workbench/contrib/welcome/page/browser/welcomePage.css b/src/sql/workbench/contrib/welcome/page/browser/welcomePage.css index c9ae2f5199..db7f63f2cd 100644 --- a/src/sql/workbench/contrib/welcome/page/browser/welcomePage.css +++ b/src/sql/workbench/contrib/welcome/page/browser/welcomePage.css @@ -1195,7 +1195,7 @@ } .ads_homepage .extension_pack_description { - background: url(../../media/extension_pack_img.png); + background: url(../../media/extension_pack_img.svg); background-size: cover; background-position: center; position: relative; diff --git a/src/sql/workbench/contrib/welcome/page/browser/welcomePage.ts b/src/sql/workbench/contrib/welcome/page/browser/welcomePage.ts index be6bdbb907..3c3ada731a 100644 --- a/src/sql/workbench/contrib/welcome/page/browser/welcomePage.ts +++ b/src/sql/workbench/contrib/welcome/page/browser/welcomePage.ts @@ -315,20 +315,11 @@ class WelcomePage extends Disposable { } } })); - this.addVideoImageSource(); this.createDropDown(); this.createWidePreviewToolTip(); this.createPreviewModal(); } - private addVideoImageSource() { - const videoIntroduction = document.querySelector('#video_introduction') as HTMLImageElement; - const videoOverview = document.querySelector('#video_overview') as HTMLImageElement; - - videoIntroduction.src = require.toUrl('./../../media/video_introduction.png'); - videoOverview.src = require.toUrl('./../../media/video_overview.png'); - } - private createWidePreviewToolTip() { const previewLink = document.querySelector('#tool_tip_container_wide'); const tooltip = document.querySelector('#tooltip_text_wide');