No browser from common (#7178)

* no browser from common

* clean up some imports

src/sql/workbench/services/connection/browser/connectionDialogWidget.ts

@@ -17,7 +17,7 @@ import { TabbedPanel, PanelTabIdentifier } from 'sql/base/browser/ui/panel/panel
 import { RecentConnectionTreeController, RecentConnectionActionsProvider } from 'sql/workbench/parts/connection/browser/recentConnectionTreeController';
 import { SavedConnectionTreeController } from 'sql/workbench/parts/connection/browser/savedConnectionTreeController';
 import * as TelemetryKeys from 'sql/platform/telemetry/common/telemetryKeys';
-import { ClearRecentConnectionsAction } from 'sql/workbench/parts/connection/common/connectionActions';
+import { ClearRecentConnectionsAction } from 'sql/workbench/parts/connection/browser/connectionActions';
 import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey';
 import { contrastBorder } from 'vs/platform/theme/common/colorRegistry';
 import { Event, Emitter } from 'vs/base/common/event';

src/sql/workbench/services/connection/test/browser/connectionDialogService.test.ts

@@ -5,7 +5,7 @@
 
 import { ConnectionDialogService } from 'sql/workbench/services/connection/browser/connectionDialogService';
 import { ConnectionDialogWidget } from 'sql/workbench/services/connection/browser/connectionDialogWidget';
-import { ConnectionManagementService } from 'sql/platform/connection/common/connectionManagementService';
+import { ConnectionManagementService } from 'sql/platform/connection/browser/connectionManagementService';
 import { ConnectionType, IConnectableInput, IConnectionResult, INewConnectionParams } from 'sql/platform/connection/common/connectionManagement';
 import { TestErrorMessageService } from 'sql/platform/errorMessage/test/common/testErrorMessageService';
 

src/sql/workbench/services/insights/browser/insightsDialogController.ts

@@ -8,7 +8,7 @@ import { IConnectionProfile } from 'sql/platform/connection/common/interfaces';
 import QueryRunner from 'sql/platform/query/common/queryRunner';
 import * as Utils from 'sql/platform/connection/common/utils';
 import { IErrorMessageService } from 'sql/platform/errorMessage/common/errorMessageService';
-import { resolveQueryFilePath } from './insightsUtils';
+import { resolveQueryFilePath } from '../common/insightsUtils';
 
 import { DbCellValue, IDbColumn, QueryExecuteSubsetResult } from 'azdata';
 

src/sql/workbench/services/insights/browser/insightsDialogService.ts

@@ -6,7 +6,7 @@ import { Event } from 'vs/base/common/event';
 import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
 
 import { IConnectionProfile } from 'sql/platform/connection/common/interfaces';
-import { BaseActionContext } from 'sql/workbench/common/actions';
+import { BaseActionContext } from 'sql/workbench/browser/actions';
 import { IInsightsConfigDetails, IInsightsConfig } from 'sql/platform/dashboard/browser/insightRegistry';
 
 export interface IInsightsDialogModel {

src/sql/workbench/services/insights/browser/insightsDialogServiceImpl.ts

@@ -9,7 +9,7 @@ import { IConnectionProfile } from 'sql/platform/connection/common/interfaces';
 import { IInsightsDialogModel, IInsightsDialogService } from 'sql/workbench/services/insights/browser/insightsDialogService';
 import { InsightsDialogModel } from 'sql/workbench/services/insights/browser/insightsDialogModel';
 import { IInsightsConfig } from 'sql/platform/dashboard/browser/insightRegistry';
-import { InsightsDialogController } from 'sql/workbench/services/insights/common/insightsDialogController';
+import { InsightsDialogController } from 'sql/workbench/services/insights/browser/insightsDialogController';
 
 export class InsightsDialogService implements IInsightsDialogService {
 	_serviceBrand: any;

src/sql/workbench/services/insights/test/browser/insightsDialogController.test.ts

@@ -3,9 +3,9 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { InsightsDialogController } from 'sql/workbench/services/insights/common/insightsDialogController';
+import { InsightsDialogController } from 'sql/workbench/services/insights/browser/insightsDialogController';
 import QueryRunner from 'sql/platform/query/common/queryRunner';
-import { ConnectionManagementService } from 'sql/platform/connection/common/connectionManagementService';
+import { ConnectionManagementService } from 'sql/platform/connection/browser/connectionManagementService';
 import { IConnectionProfile } from 'sql/platform/connection/common/interfaces';
 
 import { InstantiationService } from 'vs/platform/instantiation/common/instantiationService';

src/sql/workbench/services/notebook/browser/notebookService.ts

@@ -9,11 +9,11 @@ import { Event } from 'vs/base/common/event';
 import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
 import { URI } from 'vs/base/common/uri';
 import { RenderMimeRegistry } from 'sql/workbench/parts/notebook/browser/outputs/registry';
-import { ModelFactory } from 'sql/workbench/parts/notebook/common/models/modelFactory';
+import { ModelFactory } from 'sql/workbench/parts/notebook/browser/models/modelFactory';
 import { IConnectionProfile } from 'sql/platform/connection/common/interfaces';
 import { NotebookInput } from 'sql/workbench/parts/notebook/browser/models/notebookInput';
 import { ISingleNotebookEditOperation } from 'sql/workbench/api/common/sqlExtHostTypes';
-import { ICellModel, INotebookModel } from 'sql/workbench/parts/notebook/common/models/modelInterfaces';
+import { ICellModel, INotebookModel } from 'sql/workbench/parts/notebook/browser/models/modelInterfaces';
 import { NotebookChangeType } from 'sql/workbench/parts/notebook/common/models/contracts';
 import { IBootstrapParams } from 'sql/platform/bootstrap/common/bootstrapParams';
 

src/sql/workbench/services/notebook/browser/notebookServiceImpl.ts

@@ -11,7 +11,7 @@ import { Registry } from 'vs/platform/registry/common/platform';
 import {
 	INotebookService, INotebookManager, INotebookProvider,
 	DEFAULT_NOTEBOOK_FILETYPE, INotebookEditor, SQL_NOTEBOOK_PROVIDER, OVERRIDE_EDITOR_THEMING_SETTING, INavigationProvider, ILanguageMagic
-} from 'sql/workbench/services/notebook/common/notebookService';
+} from 'sql/workbench/services/notebook/browser/notebookService';
 import { RenderMimeRegistry } from 'sql/workbench/parts/notebook/browser/outputs/registry';
 import { standardRendererFactories } from 'sql/workbench/parts/notebook/browser/outputs/factories';
 import { Extensions, INotebookProviderRegistry, NotebookProviderRegistration } from 'sql/workbench/services/notebook/common/notebookRegistry';
@@ -30,9 +30,9 @@ import { NotebookEditor } from 'sql/workbench/parts/notebook/browser/notebookEdi
 import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
 import { registerNotebookThemes } from 'sql/workbench/parts/notebook/browser/notebookStyles';
 import { IQueryManagementService } from 'sql/platform/query/common/queryManagement';
-import { notebookConstants, ICellModel } from 'sql/workbench/parts/notebook/common/models/modelInterfaces';
+import { notebookConstants, ICellModel } from 'sql/workbench/parts/notebook/browser/models/modelInterfaces';
 import { ILifecycleService } from 'vs/platform/lifecycle/common/lifecycle';
-import { SqlNotebookProvider } from 'sql/workbench/services/notebook/common/sql/sqlNotebookProvider';
+import { SqlNotebookProvider } from 'sql/workbench/services/notebook/browser/sql/sqlNotebookProvider';
 import { IEditorGroupsService } from 'vs/workbench/services/editor/common/editorGroupsService';
 import { keys } from 'vs/base/common/map';
 import { IFileService, IFileStatWithMetadata } from 'vs/platform/files/common/files';

src/sql/workbench/services/notebook/browser/sessionManager.ts

@@ -5,7 +5,7 @@
 
 import { nb } from 'azdata';
 import { localize } from 'vs/nls';
-import { FutureInternal } from 'sql/workbench/parts/notebook/common/models/modelInterfaces';
+import { FutureInternal } from 'sql/workbench/parts/notebook/browser/models/modelInterfaces';
 import { ConnectionProfile } from 'sql/platform/connection/common/connectionProfile';
 
 export const noKernel: string = localize('noKernel', "No Kernel");
@@ -226,4 +226,4 @@ export class EmptyFuture implements FutureInternal {
 	removeMessageHook(hook: (msg: nb.IIOPubMessage) => boolean | Thenable<boolean>): void {
 		// no-op
 	}
-}
+}

src/sql/workbench/services/notebook/browser/sql/sqlNotebookManager.ts

@@ -7,9 +7,9 @@ import { nb } from 'azdata';
 import * as vscode from 'vscode';
 
 import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
-import { SQL_NOTEBOOK_PROVIDER } from 'sql/workbench/services/notebook/common/notebookService';
+import { SQL_NOTEBOOK_PROVIDER } from 'sql/workbench/services/notebook/browser/notebookService';
 import { LocalContentManager } from 'sql/workbench/services/notebook/common/localContentManager';
-import { SqlSessionManager } from 'sql/workbench/services/notebook/common/sql/sqlSessionManager';
+import { SqlSessionManager } from 'sql/workbench/services/notebook/browser/sql/sqlSessionManager';
 
 export class SqlNotebookManager implements nb.NotebookProvider {
 	private _contentManager: nb.ContentManager;

src/sql/workbench/services/notebook/browser/sql/sqlNotebookProvider.ts

@@ -6,8 +6,8 @@
 import { URI } from 'vs/base/common/uri';
 
 import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
-import { INotebookManager, INotebookProvider, SQL_NOTEBOOK_PROVIDER } from 'sql/workbench/services/notebook/common/notebookService';
-import { SqlNotebookManager } from 'sql/workbench/services/notebook/common/sql/sqlNotebookManager';
+import { INotebookManager, INotebookProvider, SQL_NOTEBOOK_PROVIDER } from 'sql/workbench/services/notebook/browser/notebookService';
+import { SqlNotebookManager } from 'sql/workbench/services/notebook/browser/sql/sqlNotebookManager';
 
 export class SqlNotebookProvider implements INotebookProvider {
 	private manager: SqlNotebookManager;

src/sql/workbench/services/notebook/browser/sql/sqlSessionManager.ts

@@ -5,7 +5,7 @@
 
 import { nb, QueryExecuteSubsetResult, IDbColumn, BatchSummary, IResultMessage, ResultSetSummary } from 'azdata';
 import { localize } from 'vs/nls';
-import { FutureInternal, notebookConstants } from 'sql/workbench/parts/notebook/common/models/modelInterfaces';
+import { FutureInternal, notebookConstants } from 'sql/workbench/parts/notebook/browser/models/modelInterfaces';
 import QueryRunner from 'sql/platform/query/common/queryRunner';
 import { IConnectionManagementService } from 'sql/platform/connection/common/connectionManagement';
 import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
@@ -16,12 +16,12 @@ import { IErrorMessageService } from 'sql/platform/errorMessage/common/errorMess
 import { ConnectionProfile } from 'sql/platform/connection/common/connectionProfile';
 import { IConnectionProfile } from 'sql/platform/connection/common/interfaces';
 import { escape } from 'sql/base/common/strings';
-import * as notebookUtils from 'sql/workbench/parts/notebook/common/models/notebookUtils';
+import * as notebookUtils from 'sql/workbench/parts/notebook/browser/models/notebookUtils';
 import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
 import { ICapabilitiesService } from 'sql/platform/capabilities/common/capabilitiesService';
 import { ILogService } from 'vs/platform/log/common/log';
 import { isUndefinedOrNull } from 'vs/base/common/types';
-import { ILanguageMagic } from 'sql/workbench/services/notebook/common/notebookService';
+import { ILanguageMagic } from 'sql/workbench/services/notebook/browser/notebookService';
 import { ITextResourcePropertiesService } from 'vs/editor/common/services/resourceConfiguration';
 import { URI } from 'vs/base/common/uri';
 import { getUriPrefix, uriPrefixes } from 'sql/platform/connection/common/utils';

src/sql/workbench/services/objectExplorer/test/browser/objectExplorerService.test.ts

@@ -5,7 +5,7 @@
 
 import { ConnectionProfile } from 'sql/platform/connection/common/connectionProfile';
 import { ConnectionProfileGroup } from 'sql/platform/connection/common/connectionProfileGroup';
-import { ObjectExplorerService, NodeExpandInfoWithProviderId } from 'sql/workbench/services/objectExplorer/common/objectExplorerService';
+import { ObjectExplorerService, NodeExpandInfoWithProviderId } from 'sql/workbench/services/objectExplorer/browser/objectExplorerService';
 import { NodeType } from 'sql/workbench/parts/objectExplorer/common/nodeType';
 import { TreeNode, TreeItemCollapsibleState } from 'sql/workbench/parts/objectExplorer/common/treeNode';
 

src/sql/workbench/services/profiler/browser/profilerFilter.ts

@@ -3,7 +3,7 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { ProfilerFilterClause, ProfilerFilter, ProfilerFilterClauseOperator } from 'sql/workbench/services/profiler/common/interfaces';
+import { ProfilerFilterClause, ProfilerFilter, ProfilerFilterClauseOperator } from 'sql/workbench/services/profiler/browser/interfaces';
 
 
 export function FilterData(filter: ProfilerFilter, data: any[]): any[] {

src/sql/workbench/services/profiler/browser/profilerService.ts

@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { IConnectionManagementService, IConnectionCompletionOptions, ConnectionType, RunQueryOnConnectionMode } from 'sql/platform/connection/common/connectionManagement';
-import { ProfilerSessionID, IProfilerSession, IProfilerService, IProfilerViewTemplate, IProfilerSessionTemplate, PROFILER_SETTINGS, IProfilerSettings, EngineType, ProfilerFilter, PROFILER_FILTER_SETTINGS } from '../common/interfaces';
+import { ProfilerSessionID, IProfilerSession, IProfilerService, IProfilerViewTemplate, IProfilerSessionTemplate, PROFILER_SETTINGS, IProfilerSettings, EngineType, ProfilerFilter, PROFILER_FILTER_SETTINGS } from './interfaces';
 import { IConnectionProfile } from 'sql/platform/connection/common/interfaces';
 import { ProfilerInput } from 'sql/workbench/parts/profiler/browser/profilerInput';
 import { ProfilerColumnEditorDialog } from 'sql/workbench/parts/profiler/browser/profilerColumnEditorDialog';

src/sql/workbench/services/profiler/test/browser/profilerFilter.test.ts

@@ -4,8 +4,8 @@
  *--------------------------------------------------------------------------------------------*/
 
 import * as assert from 'assert';
-import { FilterData } from 'sql/workbench/services/profiler/common/profilerFilter';
-import { ProfilerFilterClauseOperator, ProfilerFilter } from 'sql/workbench/services/profiler/common/interfaces';
+import { FilterData } from 'sql/workbench/services/profiler/browser/profilerFilter';
+import { ProfilerFilterClauseOperator, ProfilerFilter } from 'sql/workbench/services/profiler/browser/interfaces';
 
 const property1 = 'property1';
 const property2 = 'property2';
@@ -117,4 +117,3 @@ interface TestData {
 	property1: string;
 	property2: string;
 }
-

src/sql/workbench/services/queryEditor/browser/queryEditorService.ts

@@ -9,7 +9,7 @@ import { EditDataInput } from 'sql/workbench/parts/editData/browser/editDataInpu
 import { IConnectableInput, IConnectionManagementService } from 'sql/platform/connection/common/connectionManagement';
 import { IQueryEditorService, IQueryEditorOptions } from 'sql/workbench/services/queryEditor/common/queryEditorService';
 import { QueryPlanInput } from 'sql/workbench/parts/queryPlan/common/queryPlanInput';
-import { sqlModeId, untitledFilePrefix, getSupportedInputResource } from 'sql/workbench/common/customInputConverter';
+import { sqlModeId, untitledFilePrefix, getSupportedInputResource } from 'sql/workbench/browser/customInputConverter';
 import * as TaskUtilities from 'sql/workbench/browser/taskUtilities';
 
 import { ITextModel } from 'vs/editor/common/model';