ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-28 09:35:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix issues with loading aliased kernels in notebooks (#21018)

Browse Source
This commit is contained in:
Cory Rivera
2022-10-28 13:22:52 -07:00
committed by GitHub
parent 5fdb20f79c
commit 82adcc0f20
3 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/workbench/contrib/notebook/browser/notebookActions.ts
View File

@@ -597,7 +597,7 @@ export class KernelsDropdown extends SelectBox {
this._register(this.model.kernelChanged((changedArgs: azdata.nb.IKernelChangedArgs) => {
this.updateKernel(changedArgs.newValue, changedArgs.nbKernelAlias);
}));
this._register(this.model.kernelsChanged(kernel => {
this._register(this.model.kernelsAdded(kernel => {
this.updateKernel(kernel);
}));
let kernel = this.model.clientSession && this.model.clientSession.kernel;

4
src/sql/workbench/contrib/notebook/test/electron-browser/notebookModel.test.ts
View File

@@ -1085,7 +1085,7 @@ suite('notebook model', function (): void {
supportedFileExtensions: [DEFAULT_NOTEBOOK_FILETYPE]
};
let kernelsAddedPromise = new Promise<void>(resolve => {
model.kernelsChanged(kernel => {
model.kernelsAdded(kernel => {
resolve();
});
});
@@ -1110,7 +1110,7 @@ suite('notebook model', function (): void {
supportedFileExtensions: ['.html']
};
kernelsAddedPromise = new Promise<void>((resolve, reject) => {
model.kernelsChanged(kernel => {
model.kernelsAdded(kernel => {
reject('Should not have added a new kernel');
});
});