ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-15 01:25:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix modal event propagation (#8050)

Browse Source 
* Fix event propagation

* Remove unneeded onkeyup method

* Move event handling code into SQL classes
This commit is contained in:
Charles Gagnon
2019-10-30 11:29:01 -07:00
committed by GitHub
parent 004297aea6
commit 82e5221024
8 changed files with 59 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/sql/workbench/browser/modelComponents/inputbox.component.ts
View File

@@ -22,6 +22,7 @@ import * as nls from 'vs/nls';
import { inputBackground, inputBorder } from 'vs/platform/theme/common/colorRegistry';
import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent';
import { KeyCode } from 'vs/base/common/keyCodes';
import * as DOM from 'vs/base/browser/dom';
@Component({
selector: 'modelview-inputBox',
@@ -78,7 +79,7 @@ export default class InputBoxComponent extends ComponentBase implements ICompone
args: this._input.value
});
if (this.stopEnterPropagation) {
e.stopPropagation();
DOM.EventHelper.stop(e, true);
}
}
});
@@ -89,7 +90,7 @@ export default class InputBoxComponent extends ComponentBase implements ICompone
this._textAreaInput = new InputBox(this._textareaContainer.nativeElement, this.contextViewService, textAreaInputOptions);
this.onkeydown(this._textAreaInput.inputElement, (e: StandardKeyboardEvent) => {
if (this.tryHandleKeyEvent(e)) {
e.stopPropagation();
DOM.EventHelper.stop(e, true);
}
if (e.keyCode === KeyCode.Enter) {
this.fireEvent({
@@ -97,7 +98,7 @@ export default class InputBoxComponent extends ComponentBase implements ICompone
args: this._textAreaInput.value
});
if (this.stopEnterPropagation) {
e.stopPropagation();
DOM.EventHelper.stop(e, true);
}
}
// Else assume that keybinding service handles routing this to a command