From 83698a14b069897e62a1c54c90f2f185da2fa516 Mon Sep 17 00:00:00 2001 From: Candice Ye Date: Wed, 16 Feb 2022 21:06:51 -0800 Subject: [PATCH] Fixed color contrast for error message in connect a dc window. (#18411) * Fixed color contrast for error message in connect a dc window. * Remove color check for error message * Remove more unneeded checks Co-authored-by: Charles Gagnon --- .../arc/src/test/ui/components/radioOptionsGroup.test.ts | 3 --- extensions/arc/src/ui/components/radioOptionsGroup.ts | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/extensions/arc/src/test/ui/components/radioOptionsGroup.test.ts b/extensions/arc/src/test/ui/components/radioOptionsGroup.test.ts index 69297eeae1..196b4a8129 100644 --- a/extensions/arc/src/test/ui/components/radioOptionsGroup.test.ts +++ b/extensions/arc/src/test/ui/components/radioOptionsGroup.test.ts @@ -52,9 +52,6 @@ describe('radioOptionsGroup', function (): void { const label = radioOptionsGroup.items[0] as azdata.TextComponent; should(label.value).not.be.undefined(); label.value!.should.deepEqual(loc.loadingClusterContextsError(loadingError)); - should(label.CSSStyles).not.be.undefined(); - should(label.CSSStyles!.color).not.be.undefined(); - label.CSSStyles!.color.should.equal('Red'); }); describe('getters and setters', async () => { diff --git a/extensions/arc/src/ui/components/radioOptionsGroup.ts b/extensions/arc/src/ui/components/radioOptionsGroup.ts index 05b68beefb..a491493ab3 100644 --- a/extensions/arc/src/ui/components/radioOptionsGroup.ts +++ b/extensions/arc/src/ui/components/radioOptionsGroup.ts @@ -67,7 +67,7 @@ export class RadioOptionsGroup { this.component().loadingCompletedText = this._loadingCompleteMessage; } catch (e) { - const errorLabel = this._modelBuilder.text().withProps({ value: loc.loadingClusterContextsError(e), CSSStyles: { 'color': 'Red' } }).component(); + const errorLabel = this._modelBuilder.text().withProps({ value: loc.loadingClusterContextsError(e), textType: azdata.TextType.Error }).component(); this._divContainer.addItem(errorLabel); this.component().loadingCompletedText = this._loadingCompleteErrorMessage(e); }