From 84001139ccf99f384b86389106382ce018565f9b Mon Sep 17 00:00:00 2001 From: Christopher Suh Date: Tue, 1 Mar 2022 18:26:58 -0800 Subject: [PATCH] Update CI to windows-2019 (#18606) * Revert "Update CI for new windows-latest (#18585)" This reverts commit ebd4c6844bb65a9928905ce6ed960d194d973529. * update to windows-2019 --- .github/workflows/ci.yml | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5bf9ba30a3..ed9050bcb5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,7 @@ on: jobs: windows: name: Windows - runs-on: windows-latest + runs-on: windows-2019 timeout-minutes: 30 env: CHILD_CONCURRENCY: "1" @@ -59,14 +59,7 @@ jobs: env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 ELECTRON_SKIP_BINARY_DOWNLOAD: 1 - run: | - # update node-gyp to latest for support in detecting VS 2022 toolchain - npm install -g node-gyp@latest - # Resolve to node-gyp.js - # Remove this once node-version > 17.4.x or > 16.14.0, - # which ships with npm > 8.4.0 that has support for VS 2022 toolchain. - $env:npm_config_node_gyp=$(Join-Path $(Get-Command node-gyp.cmd).Path "..\node_modules\node-gyp\bin\node-gyp.js" -Resolve) - yarn --frozen-lockfile --network-timeout 180000 + run: yarn --frozen-lockfile --network-timeout 180000 # - name: Create node_modules archive {{SQL CARBON EDIT}} Skip caching for now # if: ${{ steps.cacheNodeModules.outputs.cache-hit != 'true' }} # run: |