From 84ae306d57869dcf94c8ef72ed75e36439ec0c8f Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Wed, 3 Nov 2021 19:48:04 -0700 Subject: [PATCH] Fix not being able to type in code cell after switching from text (#17590) * Fix not being able to type in code cell after switching from text * comment --- .../contrib/notebook/browser/cellViews/textCell.component.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts b/src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts index 24fb69ea4e..4c304fdf67 100644 --- a/src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts +++ b/src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts @@ -509,7 +509,9 @@ export class TextCellComponent extends CellView implements OnInit, OnChanges { // Move cursor to the richTextCursorPosition // We iterate through the output element childnodes to get to the element of cursor location // If the elements exist, we set the selection, else the cursor defaults to beginning. - if (!this.markdownMode && this.cellModel.richTextCursorPosition) { + // Only do this if the cell is active so we don't steal the window selection from another cell + // since this function is called whenever any cell in the Notebook changes, not just ourself + if (this.isActive() && !this.markdownMode && this.cellModel.richTextCursorPosition) { let selection = window.getSelection(); let htmlNodes = this.cellModel.richTextCursorPosition.startElementNodes; let depthToNode = htmlNodes.length;