ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-09 09:42:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

[Port] Improved behavior for accepting EULA. (#12453) (#12749)

Browse Source 
* Improved behavior for accepting EULA. (#12453)

* working version of overloading "select" button

* promptForEula to use showErrorMessage

* make parameter optional in promptForEula

* remove test code

* PR feedback

* eula to EULA

* minor fix

* Fix compile error

Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com>
This commit is contained in:
Charles Gagnon
2020-10-05 18:52:16 -07:00
committed by GitHub
parent 4c6b606c82
commit 867faae14f
8 changed files with 81 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/resource-deployment/src/services/tools/toolBase.ts
View File

@@ -58,7 +58,9 @@ export abstract class ToolBase implements ITool {
protected abstract readonly versionCommand: Command;
public validateEula(): boolean { return true; }
public isEulaAccepted(): boolean { return true; }
public promptForEula(): Promise<boolean> { return Promise.resolve(true); }
public get dependencyMessages(): string[] {
return (this.dependenciesByOsType.get(this.osDistribution) || []).map((msgType: dependencyType) => messageByDependencyType.get(msgType)!);