From 86a9a2c069f61abed34ac95fa8d5e8833716b0ad Mon Sep 17 00:00:00 2001 From: Amir Omidi Date: Wed, 18 Sep 2019 10:59:58 -0700 Subject: [PATCH] NaN checks aren't possible with an equality check (#7268) --- src/sql/base/browser/ui/table/tableDataView.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sql/base/browser/ui/table/tableDataView.ts b/src/sql/base/browser/ui/table/tableDataView.ts index 8e8c7a6738..43225fe5d0 100644 --- a/src/sql/base/browser/ui/table/tableDataView.ts +++ b/src/sql/base/browser/ui/table/tableDataView.ts @@ -22,7 +22,7 @@ function defaultSort(args: Slick.OnSortEventAr const sign = args.sortAsc ? 1 : -1; let comparer: (a: T, b: T) => number; if (types.isString(data[0][field])) { - if (Number(data[0][field]) !== NaN) { + if (!isNaN(Number(data[0][field]))) { comparer = (a: T, b: T) => { let anum = Number(a[field]); let bnum = Number(b[field]);