From 8782eeb32f1360dbb6f49983e835ff60c548692b Mon Sep 17 00:00:00 2001 From: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com> Date: Fri, 18 Sep 2020 17:44:58 -0700 Subject: [PATCH] Port/ml fixes (#12491) * change to allow refresh and delete correctly (#12477) * add table name to models that are imported (#12445) --- .../src/views/models/manageModels/currentModelsTable.ts | 4 ++-- .../src/views/models/manageModels/modelImportLocationPage.ts | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/extensions/machine-learning/src/views/models/manageModels/currentModelsTable.ts b/extensions/machine-learning/src/views/models/manageModels/currentModelsTable.ts index 2649caf60e..4192cca97f 100644 --- a/extensions/machine-learning/src/views/models/manageModels/currentModelsTable.ts +++ b/extensions/machine-learning/src/views/models/manageModels/currentModelsTable.ts @@ -186,13 +186,13 @@ export class CurrentModelsTable extends ModelViewBase implements IDataComponent< public async onLoading(): Promise { if (this._loader) { - await this._loader.updateProperties({ loading: true }); + this._loader.loading = true; } } public async onLoaded(): Promise { if (this._loader) { - await this._loader.updateProperties({ loading: false }); + this._loader.loading = false; } } diff --git a/extensions/machine-learning/src/views/models/manageModels/modelImportLocationPage.ts b/extensions/machine-learning/src/views/models/manageModels/modelImportLocationPage.ts index 7880cccdb2..63d940dd3c 100644 --- a/extensions/machine-learning/src/views/models/manageModels/modelImportLocationPage.ts +++ b/extensions/machine-learning/src/views/models/manageModels/modelImportLocationPage.ts @@ -99,6 +99,11 @@ export class ModelImportLocationPage extends ModelViewBase implements IPageView, } if (this.importTable && this._labelComponent) { + + // Add table name to the models imported. + // Since Table name is picked last as per new flow this hasn't been set yet. + this.modelsViewData?.forEach(x => x.targetImportTable = this.importTable); + if (!this.validateImportTableName()) { this._labelComponent.value = constants.selectModelsTableMessage; } else {