From 883dcc978927ebfa0baa8857c6438be4cc1a06ad Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Wed, 22 Apr 2020 09:50:37 -0700 Subject: [PATCH] Fix view destroyed errors (#10119) --- .../propertiesContainer/propertiesContainer.component.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/sql/base/browser/ui/propertiesContainer/propertiesContainer.component.ts b/src/sql/base/browser/ui/propertiesContainer/propertiesContainer.component.ts index 9ab169dbf1..91727a90b6 100644 --- a/src/sql/base/browser/ui/propertiesContainer/propertiesContainer.component.ts +++ b/src/sql/base/browser/ui/propertiesContainer/propertiesContainer.component.ts @@ -4,7 +4,7 @@ *--------------------------------------------------------------------------------------------*/ import 'vs/css!./media/propertiesContainer'; -import { Component, Inject, forwardRef, ChangeDetectorRef, OnInit, ElementRef } from '@angular/core'; +import { Component, Inject, forwardRef, ChangeDetectorRef, OnInit, ElementRef, OnDestroy } from '@angular/core'; import { EventType, addDisposableListener } from 'vs/base/browser/dom'; import * as nls from 'vs/nls'; import { Disposable } from 'vs/base/common/lifecycle'; @@ -32,7 +32,7 @@ const verticalPropertyHeight = 46; selector: 'properties-container', templateUrl: decodeURI(require.toUrl('./propertiesContainer.component.html')) }) -export class PropertiesContainer extends Disposable implements OnInit { +export class PropertiesContainer extends Disposable implements OnInit, OnDestroy { public gridDisplayLayout = GridDisplayLayout.twoColumns; public propertyLayout = PropertyLayoutDirection.row; public loadingMessage: string = nls.localize('loadingProperties', "Loading properties"); @@ -54,6 +54,10 @@ export class PropertiesContainer extends Disposable implements OnInit { this._changeRef.detectChanges(); } + ngOnDestroy() { + this.dispose(); + } + private layoutDisplayProperties(): void { // Reflow: // 2 columns w/ horizontal alignment : 1366px and above