Fix #1198 Extension gallery doesn't show dashboard contributions in Contributions tab (#1200)

- Showing dashboard.tabs and dashboard.insights in Contributions
- Decided not to show dashboard.containers for now since these are logically just parts of the tabs, and dont' have user-facing benefit.
This commit is contained in:
Kevin Cunnane
2018-04-22 17:42:44 -07:00
committed by GitHub
parent a7c4686980
commit 891624c085
5 changed files with 122 additions and 7 deletions

View File

@@ -54,6 +54,9 @@ import { IEnvironmentService } from 'vs/platform/environment/common/environment'
import { assign } from 'vs/base/common/objects';
import { INotificationService } from 'vs/platform/notification/common/notification';
// {{SQL CARBON EDIT}}
import { renderDashboardContributions } from 'sql/parts/extensions/sqlExtensionsHelper';
/** A context key that is set when an extension editor webview has focus. */
export const KEYBINDING_CONTEXT_EXTENSIONEDITOR_WEBVIEW_FOCUS = new RawContextKey<boolean>('extensionEditorWebviewFocus', undefined);
/** A context key that is set when the find widget find input in extension editor webview is focused. */
@@ -474,7 +477,9 @@ export class ExtensionEditor extends BaseEditor {
this.renderJSONValidation(content, manifest, layout),
this.renderDebuggers(content, manifest, layout),
this.renderViews(content, manifest, layout),
this.renderLocalizations(content, manifest, layout)
this.renderLocalizations(content, manifest, layout),
// {{SQL CARBON EDIT}}
renderDashboardContributions(content, manifest, layout)
];
const isEmpty = !renders.reduce((v, r) => r || v, false);

View File

@@ -59,7 +59,7 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
private _fileBasedRecommendations: { [id: string]: number; } = Object.create(null);
// {{SQL CARBON EDIT}}
private _recommendations: string[] = Object.create(null);
private _recommendations: string[] = [];
private _exeBasedRecommendations: { [id: string]: string; } = Object.create(null);
private _availableRecommendations: { [pattern: string]: string[] } = Object.create(null);
private _allWorkspaceRecommendedExtensions: string[] = [];