ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-15 09:35:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

OptionsMapTable logic to replace the deployment hardcoded values final (#19789)

Browse Source 
* OptionsMapTable logic to replace the deployment hardcoded values final

* Test modifiaction

* OptionsMApTable updates with STS and review commetns

* comments added and option string moved to constants file

* Reverting the options button css related change and will put in other PR

* converted optionsMapTable to custom type and references.

* Options prop changes and model updates

* Reset btn event method name fixed

* removed local booleanOptionDict var and using the existing one

* updated code with removed local vars

* Update to booleanOptionsDictionary name

* merged two variable to one

* Refactoring code and updating variables

* separated lookup and data array and refactor

* missing visibility

* reset logic revised and no other edgecases found

* variable names updated to meaningful

* vbump here to test the checks, sending new vbump PR separately
This commit is contained in:
Sai Avishkar Sreerama
2022-07-08 09:40:06 -05:00
committed by GitHub
parent 84a15ea91d
commit 89816c9ff3
11 changed files with 116 additions and 628 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
extensions/sql-database-projects/src/test/models/deployOptionsModel.test.ts
View File

@@ -13,19 +13,18 @@ describe('Publish Dialog Deploy Options Model', () => {
should.notEqual(model.getOptionsData(), undefined, 'Options shouldn\'t be undefined');
should.doesNotThrow(() => model.setDeploymentOptions());
should(model.getDeployOptionUtil('')).equal(undefined);
});
it('Should get description', function (): void {
const model = new DeployOptionsModel(testUtils.getDeploymentOptions());
model.optionsLabels.forEach(l => {
should(model.getDescription(l)).not.equal(undefined);
Object.entries(model.deploymentOptions.booleanOptionsDictionary).forEach(option => {
// option[1] contains the value, description and displayName
should(model.getOptionDescription(option[1].displayName)).not.equal(undefined);
});
});
it('Should be undefined for null description', function (): void {
it('Should return empty string for null option ', function (): void {
const model = new DeployOptionsModel(testUtils.getDeploymentOptions());
should(model.getDescription('')).equal(undefined);
should(model.getOptionDescription('')).equal('');
});
});