ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix changing kernels from kusto to other kernels (#15545)

Browse Source
This commit is contained in:
Vasu Bhog
2021-05-24 13:52:32 -07:00
committed by GitHub
parent a7ad526ff2
commit 8a0c183114
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sql/workbench/services/notebook/browser/models/notebookModel.ts
View File

@@ -964,14 +964,18 @@ export class NotebookModel extends Disposable implements INotebookModel {
private async updateKernelInfoOnKernelChange(kernel: nb.IKernel, kernelAlias?: string) { private async updateKernelInfoOnKernelChange(kernel: nb.IKernel, kernelAlias?: string) {
await this.updateKernelInfo(kernel); await this.updateKernelInfo(kernel);
kernelAlias = this.kernelAliases.find(kernel => this._defaultLanguageInfo?.name === kernel.toLowerCase()) ?? kernelAlias; kernelAlias = this.kernelAliases.find(kernel => this._defaultLanguageInfo?.name === kernel.toLowerCase()) ?? kernelAlias;
// In order to change from kernel alias to other kernel, set kernelAlias to undefined in order to update to new kernel language info
if (this._selectedKernelDisplayName !== kernelAlias && this._selectedKernelDisplayName) {
kernelAlias = undefined;
}
// Sets the kernel alias language info properly in order to open the notebook with the kernel alias
if (kernelAlias) { if (kernelAlias) {
let aliasLanguageInfo: nb.ILanguageInfo = { let aliasLanguageInfo: nb.ILanguageInfo = {
name: kernelAlias.toLowerCase(), name: kernelAlias.toLowerCase(),
version: '' version: ''
}; };
this.updateLanguageInfo(aliasLanguageInfo); this.updateLanguageInfo(aliasLanguageInfo);
} } else if (kernel.info) {
else if (kernel.info) {
this.updateLanguageInfo(kernel.info.language_info); this.updateLanguageInfo(kernel.info.language_info);
} }
this.adstelemetryService.createActionEvent(TelemetryKeys.TelemetryView.Notebook, TelemetryKeys.NbTelemetryAction.KernelChanged) this.adstelemetryService.createActionEvent(TelemetryKeys.TelemetryView.Notebook, TelemetryKeys.NbTelemetryAction.KernelChanged)