From 8a68f0aaf9365d812d18081b69365c328a7a7496 Mon Sep 17 00:00:00 2001 From: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com> Date: Thu, 2 May 2019 10:23:26 -0700 Subject: [PATCH] Improvements to notebook editor code auto height (#5291) --- .../electron-browser/modelComponents/queryTextEditor.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/sql/workbench/electron-browser/modelComponents/queryTextEditor.ts b/src/sql/workbench/electron-browser/modelComponents/queryTextEditor.ts index 016ed0e257..d9c0c5187e 100644 --- a/src/sql/workbench/electron-browser/modelComponents/queryTextEditor.ts +++ b/src/sql/workbench/electron-browser/modelComponents/queryTextEditor.ts @@ -132,8 +132,8 @@ export class QueryTextEditor extends BaseTextEditor { public setHeightToScrollHeight(configChanged?: boolean): void { let editorWidget = this.getControl() as ICodeEditor; - if (!this._config) { - this._config = new Configuration(true, undefined, editorWidget.getDomNode(), this.accessibilityService); + this._config = new Configuration(true, undefined, editorWidget.getDomNode(), this.accessibilityService); + if (!this._scrollbarHeight) { this._scrollbarHeight = this._config.editor.viewInfo.scrollbar.horizontalScrollbarSize; } let editorWidgetModel = editorWidget.getModel(); @@ -157,7 +157,8 @@ export class QueryTextEditor extends BaseTextEditor { for (let line = 1; line <= lineCount; line++) { // 4 columns is equivalent to the viewport column width and the edge of the editor if (editorWidgetModel.getLineMaxColumn(line) >= this._config.editor.layoutInfo.viewportColumn + 4) { - numberWrappedLines += Math.ceil(editorWidgetModel.getLineMaxColumn(line) / this._config.editor.layoutInfo.viewportColumn); + // Subtract 1 because the first line should not count as a wrapped line + numberWrappedLines += Math.ceil(editorWidgetModel.getLineMaxColumn(line) / this._config.editor.layoutInfo.viewportColumn) - 1; } } } else {