From 8b4b84e5c0a6198177377e2bddc69c82372a31ed Mon Sep 17 00:00:00 2001 From: Alexander Perfilyev Date: Wed, 12 Jul 2023 15:28:23 -0700 Subject: [PATCH] Parameter renaming and number of calls reduce (#23760) Co-authored-by: Alexander Perfilyev --- extensions/sql-migration/src/constants/strings.ts | 2 +- .../sql-migration/src/wizard/skuRecommendationPage.ts | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/extensions/sql-migration/src/constants/strings.ts b/extensions/sql-migration/src/constants/strings.ts index eeb970e672..b08acb0320 100644 --- a/extensions/sql-migration/src/constants/strings.ts +++ b/extensions/sql-migration/src/constants/strings.ts @@ -141,7 +141,7 @@ export const ASSESSMENT_COMPLETED = (serverName: string): string => { export const ASSESSMENT_FAILED = (serverName: string): string => { return localize('sql.migration.assessment.failed', "The assessment of your SQL Server instance '{0}' failed.", serverName); }; -export function ASSESSMENT_TILE(serverName: string): string { +export function ASSESSMENT_TITLE(serverName: string): string { return localize('sql.migration.assessment', "Assessment results for '{0}'", serverName); } export function CAN_BE_MIGRATED(eligibleDbs: number, totalDbs: number): string { diff --git a/extensions/sql-migration/src/wizard/skuRecommendationPage.ts b/extensions/sql-migration/src/wizard/skuRecommendationPage.ts index 35d858a818..a36eff0886 100644 --- a/extensions/sql-migration/src/wizard/skuRecommendationPage.ts +++ b/extensions/sql-migration/src/wizard/skuRecommendationPage.ts @@ -417,9 +417,10 @@ export class SKURecommendationPage extends MigrationWizardPage { this._serverName = this.migrationStateModel.serverName || (await getSourceConnectionProfile()).serverName; - const miDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, constants.ASSESSMENT_TILE(this._serverName), this, MigrationTargetType.SQLMI); - const vmDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, constants.ASSESSMENT_TILE(this._serverName), this, MigrationTargetType.SQLVM); - const dbDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, constants.ASSESSMENT_TILE(this._serverName), this, MigrationTargetType.SQLDB); + const assessmentTitle = constants.ASSESSMENT_TITLE(this._serverName); + const miDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, assessmentTitle, this, MigrationTargetType.SQLMI); + const vmDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, assessmentTitle, this, MigrationTargetType.SQLVM); + const dbDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, assessmentTitle, this, MigrationTargetType.SQLDB); this._disposables.push(button.onDidClick(async (e) => { switch (this._rbg.selectedCardId) {