ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-01 09:35:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

Re-enable notebook editor unit tests (#13328)

Browse Source 
* wip

* Re-enable notebook editor tests

* PR Feedback
This commit is contained in:
Chris LaFreniere
2020-11-10 17:04:30 -08:00
committed by GitHub
parent b83da2dfa8
commit 8c6a966bb9
3 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/sql/workbench/contrib/notebook/test/testCommon.ts
View File

@@ -21,9 +21,9 @@ export class NotebookEditorStub extends stubs.NotebookEditorStub {
model: INotebookModel | undefined;
cells?: ICellModel[] = [];
public readonly id = this.notebookParams?.notebookUri?.toString();
public readonly id: string;
public readonly modelReady: Promise<INotebookModel> = Promise.resolve(this.model);
public readonly modelReady: Promise<INotebookModel>;
// Normally one needs to provide either the editor or the instantiationService as the constructor parameter
constructor({ cellGuid, instantiationService, editor, model, notebookParams }: { cellGuid?: string; instantiationService?: IInstantiationService; editor?: QueryTextEditor; model?: INotebookModel, notebookParams?: INotebookParams } = {}) {
@@ -31,6 +31,8 @@ export class NotebookEditorStub extends stubs.NotebookEditorStub {
this.model = model;
this.notebookParams = notebookParams;
this.cellEditors = [new CellEditorProviderStub({ cellGuid: cellGuid, instantiationService: instantiationService, editor: editor })];
this.id = this.notebookParams?.notebookUri?.toString();
this.modelReady = Promise.resolve(this.model);
}
}