ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-16 09:35:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update sqlcmd table to use dataValues instead of deprecated data (#13121)

Browse Source 
* Update sqlcmd table to use dataValues instead of deprecated data

* fix in declarativeTableComponent
This commit is contained in:
Kim Santiago
2020-10-29 13:19:59 -07:00
committed by GitHub
parent e15ad17967
commit 8c956cdb79
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts
View File

@@ -460,8 +460,7 @@ export class PublishDatabaseDialog {
const data = this.convertSqlCmdVarsToTableFormat(this.sqlCmdVars!);
(<azdata.DeclarativeTableComponent>this.sqlCmdVariablesTable)!.updateProperties({
dataValues: data,
data: [] // data is deprecated, but the table gets updated incorrectly if this isn't set to an empty array
dataValues: data
});
this.tryEnableGenerateScriptAndOkButtons();
@@ -569,7 +568,7 @@ export class PublishDatabaseDialog {
const data = this.convertSqlCmdVarsToTableFormat(this.getSqlCmdVariablesForPublish());
await (<azdata.DeclarativeTableComponent>this.sqlCmdVariablesTable).updateProperties({
data: data
dataValues: data
});
if (Object.keys(result.sqlCmdVariables).length) {