Add no-cond-assign rule (#17039)

This commit is contained in:
Charles Gagnon
2021-09-09 16:23:18 -07:00
committed by GitHub
parent a3b886d85b
commit 8d3b57cb76
4 changed files with 14 additions and 3 deletions

View File

@@ -10,6 +10,7 @@
"jsdoc" "jsdoc"
], ],
"rules": { "rules": {
"no-cond-assign": 2,
"@typescript-eslint/no-floating-promises": [ "@typescript-eslint/no-floating-promises": [
"error", "error",
{ {

View File

@@ -0,0 +1,5 @@
{
"rules": {
"no-cond-assign": 2
}
}

View File

@@ -0,0 +1,5 @@
{
"rules": {
"no-cond-assign": 0
}
}

View File

@@ -532,7 +532,7 @@ class ToggleCollapseAndExpandAction extends Action {
if (!viewer.isCollapsed(node)) { if (!viewer.isCollapsed(node)) {
return true; return true;
} }
} while (node = navigator.next()); } while (node = navigator.next()); // eslint-disable-line no-cond-assign
} }
return false; return false;
} }
@@ -629,7 +629,7 @@ class CollapseDeepestExpandedLevelAction extends Action {
let node = navigator.first(); let node = navigator.first();
let collapseFileMatchLevel = false; let collapseFileMatchLevel = false;
if (node instanceof FolderMatch) { if (node instanceof FolderMatch) {
while (node = navigator.next()) { while (node = navigator.next()) { // eslint-disable-line no-cond-assign
if (node instanceof Match) { if (node instanceof Match) {
collapseFileMatchLevel = true; collapseFileMatchLevel = true;
break; break;
@@ -643,7 +643,7 @@ class CollapseDeepestExpandedLevelAction extends Action {
if (node instanceof FileMatch) { if (node instanceof FileMatch) {
viewer.collapse(node); viewer.collapse(node);
} }
} while (node = navigator.next()); } while (node = navigator.next()); // eslint-disable-line no-cond-assign
} else { } else {
viewer.collapseAll(); viewer.collapseAll();
} }