diff --git a/src/sql/parts/profiler/editor/profilerEditor.ts b/src/sql/parts/profiler/editor/profilerEditor.ts index 09cd05d8d7..5324ee712b 100644 --- a/src/sql/parts/profiler/editor/profilerEditor.ts +++ b/src/sql/parts/profiler/editor/profilerEditor.ts @@ -228,7 +228,9 @@ export class ProfilerEditor extends BaseEditor { if (data) { this._modelService.updateModel(this._editorModel, data['TextData']); this._detailTableData.clear(); - this._detailTableData.push(Object.keys(data).map(key => { + this._detailTableData.push(Object.keys(data).filter(key => { + return data[key] !== ' '; + }).map(key => { return { label: key, value: data[key] diff --git a/src/sql/parts/profiler/editor/profilerInput.ts b/src/sql/parts/profiler/editor/profilerInput.ts index d9df54032a..2e42de003d 100644 --- a/src/sql/parts/profiler/editor/profilerInput.ts +++ b/src/sql/parts/profiler/editor/profilerInput.ts @@ -129,7 +129,6 @@ export class ProfilerInput extends EditorInput implements IProfilerSession { let data = {}; data['EventClass'] = e.name; data['StartTime'] = e.timestamp; - data['EndTime'] = e.timestamp; const columns = [ 'TextData', 'ApplicationName', @@ -156,12 +155,14 @@ export class ProfilerInput extends EditorInput implements IProfilerSession { columnNameMap['cpu_time'] = 'CPU'; columnNameMap['duration'] = 'Duration'; columnNameMap['logical_reads'] = 'Reads'; + columnNameMap['event_sequence'] = 'EventSequence'; + columnNameMap['client_pid'] = 'ClientProcessID'; + columnNameMap['writes'] = 'Writes'; - for (let idx = 0; idx < columns.length; ++idx) { - let columnName = columns[idx]; - data[columnName] = ''; - } - + // Using ' ' instead of '' fixed the error where clicking through events + // with empty text fields causes future text panes to be highlighted. + // This is a temporary fix, and should be changed before the July release + data['TextData'] = ' '; for (let key in e.values) { let columnName = columnNameMap[key]; if (columnName) {