From 8e72fdaa5277116436230f203476daf113b6ad0a Mon Sep 17 00:00:00 2001 From: Anthony Dresser Date: Thu, 14 Jun 2018 15:40:57 -0700 Subject: [PATCH] add aria-label for insights dialog (#1629) --- src/sql/parts/insights/browser/insightsDialogView.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/sql/parts/insights/browser/insightsDialogView.ts b/src/sql/parts/insights/browser/insightsDialogView.ts index 897d5ef522..ccb776140a 100644 --- a/src/sql/parts/insights/browser/insightsDialogView.ts +++ b/src/sql/parts/insights/browser/insightsDialogView.ts @@ -168,13 +168,16 @@ export class InsightsDialogView extends Modal { this._splitView = new SplitView(container); + const itemsHeaderTitle = nls.localize("insights.dialog.items", "Items"); + const itemsDetailHeaderTitle = nls.localize("insights.dialog.itemDetails", "Item Details"); + this._topTableData = new TableDataView(); this._bottomTableData = new TableDataView(); - let topTableView = new TableCollapsibleView(nls.localize("insights.dialog.items", "Items"), { sizing: ViewSizing.Flexible, ariaHeaderLabel: 'title' }, this._topTableData, this._topColumns, { forceFitColumns: true }); + let topTableView = new TableCollapsibleView(itemsHeaderTitle, { sizing: ViewSizing.Flexible, ariaHeaderLabel: itemsHeaderTitle }, this._topTableData, this._topColumns, { forceFitColumns: true }); this._topTable = topTableView.table; topTableView.addContainerClass('insights'); this._topTable.setSelectionModel(new RowSelectionModel()); - let bottomTableView = new TableCollapsibleView(nls.localize("insights.dialog.itemDetails", "Item Details"), { sizing: ViewSizing.Flexible, ariaHeaderLabel: 'title' }, this._bottomTableData, this._bottomColumns, { forceFitColumns: true }); + let bottomTableView = new TableCollapsibleView(itemsDetailHeaderTitle, { sizing: ViewSizing.Flexible, ariaHeaderLabel: itemsDetailHeaderTitle }, this._bottomTableData, this._bottomColumns, { forceFitColumns: true }); this._bottomTable = bottomTableView.table; this._bottomTable.setSelectionModel(new RowSelectionModel());