ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-06 17:23:53 -05:00
Code Issues Packages Projects Releases Wiki Activity

Premium SSD v2 disks in SQL VM recommendations (#24556)

Browse Source 
* Premium SSD v2 disks in SQL VM recommendations

* Resolving review comments.
This commit is contained in:
Ram Uday Kumar
2023-10-04 16:57:44 +05:30
committed by GitHub
parent 186f8d3771
commit 8f232ae3e8
7 changed files with 95 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
extensions/sql-migration/src/service/contracts.ts
View File

@@ -115,6 +115,7 @@ export interface SqlMigrationSkuRecommendationsParams {
endTime: string;
includePreviewSkus: boolean;
databaseAllowList: string[];
isPremiumSSDV2Enabled: boolean;
}
export interface AzureSqlSkuCategory {
@@ -136,6 +137,10 @@ export interface AzureManagedDiskSku {
tier: AzureManagedDiskTier;
size: string;
caching: AzureManagedDiskCaching;
type: AzureManagedDiskType;
maxSizeInGib: number;
maxThroughputInMbps: number;
maxIOPS: number;
}
export interface AzureVirtualMachineSku {
@@ -278,6 +283,15 @@ export const enum AzureManagedDiskTier {
Ultra = 2
}
// values from SQL NuGet
export const enum AzureManagedDiskType {
StandardHDD = 1, // Standard HDD
StandardSSD = 2, // Standard SSD
PremiumSSD = 4, // Premium SSD
UltraSSD = 8, // Ultra SSD
PremiumSSDV2 = 16, // Premium SSD V2
}
export const enum AzureManagedDiskCaching {
NotApplicable = 0,
None = 1,

21
extensions/sql-migration/src/service/features.ts
View File

@@ -95,16 +95,17 @@ export class SqlMigrationService extends MigrationExtensionService implements co
includePreviewSkus: boolean,
databaseAllowList: string[]): Promise<contracts.SkuRecommendationResult | undefined> {
let params: contracts.SqlMigrationSkuRecommendationsParams = {
dataFolder,
perfQueryIntervalInSec,
targetPlatforms,
targetSqlInstance,
targetPercentile,
scalingFactor,
startTime,
endTime,
includePreviewSkus,
databaseAllowList
dataFolder: dataFolder,
perfQueryIntervalInSec: perfQueryIntervalInSec,
targetPlatforms: targetPlatforms,
targetSqlInstance: targetSqlInstance,
targetPercentile: targetPercentile,
scalingFactor: scalingFactor,
startTime: startTime,
endTime: endTime,
includePreviewSkus: includePreviewSkus,
databaseAllowList: databaseAllowList,
isPremiumSSDV2Enabled: true,
};
try {